Skip processing async operations from epoll thread #35940
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #35330 (comment) by skipping state transitions when an async operation needs to be processed.
|
Tagging subscribers to this area: @dotnet/ncl |
Contributor
Author
|
Thanks for pointing this out @tmds, CC @adamsitnik, @stephentoub as well |
adamsitnik
approved these changes
May 7, 2020
Member
adamsitnik
left a comment
adamsitnik
left a comment
There was a problem hiding this comment.
LGTM, thank you for fixing it @kouvel !
tmds
approved these changes
May 7, 2020
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #35330 (comment) by skipping state transitions when looking to process sync operations and the next operation is async. Verified manually by having
IsNextOperationSynchronous_Speculativereturn true.