Skip to content

Conversation

@dagood
Copy link
Member

@dagood dagood commented Jan 17, 2020

For #906.

Requires support in the shared framework tooling: PR dotnet/arcade#4650.

I have this test build that produced the Crossgen pack by temporarily inlining the sharedfx tooling update: https://dev.azure.com/dnceng/internal/_build/results?buildId=487241

New test build for Crossgen2 pack: https://dev.azure.com/dnceng/internal/_build/results?buildId=488118&view=results

@dagood
Copy link
Member Author

dagood commented Jan 17, 2020

Filed tracking issues:

@dagood
Copy link
Member Author

dagood commented Jan 17, 2020

This is good to go, PTAL.

Here are some of the nupkgs from the test build (links need Microsoft auth)

Copy link
Contributor

@fadimounir fadimounir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I'd like someone else more familiar with the build system to also sign off on the chagnes

@fadimounir
Copy link
Contributor

Thanks for doing this work @dagood !

@dagood
Copy link
Member Author

dagood commented Jan 17, 2020

Test failures on runtime (CoreCLR Pri0 Test Run Windows_NT x64 checked) are a persistent known issue: https://github.com/dotnet/coreclr/issues/26241 (#702). I'll disregard and go ahead with the merge if approved.

@dagood dagood merged commit 1e31730 into dotnet:master Jan 17, 2020
@dagood dagood deleted the crossgen-pack branch January 17, 2020 22:01
@ghost ghost locked as resolved and limited conversation to collaborators Dec 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants