-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Add Crossgen pack for crossgen2 tool #1859
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Filed tracking issues:
|
|
This is good to go, PTAL. Here are some of the nupkgs from the test build (links need Microsoft auth) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I'd like someone else more familiar with the build system to also sign off on the chagnes
|
Thanks for doing this work @dagood ! |
|
Test failures on |
For #906.
Requires support in the shared framework tooling: PR dotnet/arcade#4650.I have this test build that produced the Crossgen pack by temporarily inlining the sharedfx tooling update: https://dev.azure.com/dnceng/internal/_build/results?buildId=487241New test build for Crossgen2 pack: https://dev.azure.com/dnceng/internal/_build/results?buildId=488118&view=results