-
Notifications
You must be signed in to change notification settings - Fork 5.3k
[release/8.0-staging] Add required MSBuild package dependencies #121307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/8.0-staging] Add required MSBuild package dependencies #121307
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the Microsoft.Build package references by replacing version variable references with hardcoded version strings and adds explicit dependency tracking entries.
Key Changes
- Replaced MSBuild version variables (
$(MicrosoftBuildVersion)) with hardcoded version string17.8.3for three MSBuild components - Added explicit dependency tracking entries in
Version.Details.xmlfor the three MSBuild packages
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| eng/Versions.props | Replaced variable references with hardcoded version 17.8.3 for MSBuild Tasks, Framework, and Utilities packages |
| eng/Version.Details.xml | Added dependency tracking entries for MSBuild Framework, Tasks Core, and Utilities Core packages |
|
Marking as |
|
Test failures seem to be the same as those seen in other PRs, i.e. #121150 One example: @bartonjs @vcsjones is this issue tracked somewhere? Test failure |
|
@NikolaMilosavljevic looks like #120527 |
|
All errors in checks are unrelated to my changes. Can this be merged now? |
|
/ba-g build timeouts |
Backport of https://github.com/dotnet/installer/blob/release/8.0.1xx/src/SourceBuild/patches/runtime/0002-Update-MSBuild-dependencies.patch
Fixes: #101395
Source-build requires explicit package versions and references for all dependencies. This PR backports the long-standing patch. It would help avoid issues with frequent patch updates.