CSE seems to fail when writing x / cns and x % cns for unsigned integers #119684
+217
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
area-CodeGen-coreclr
dotnet-policy-service
bot
added
the
community-contribution
src/coreclr/jit/morph.cpp
Outdated
Comment on lines
7410
to
7411
| else if (op1->OperIs(GT_LCL_VAR) && | ||
| (op2->OperIs(GT_LCL_VAR) || (op2->IsIntegralConst() && !op2->IsIntegralConstAbsPow2()))) |
There was a problem hiding this comment.
The comment above this needs to be updated to explain the additional change and why it is beneficial.
There was a problem hiding this comment.
I notably would've expected the fix for #119131 to simply check OperIs(GT_MOD, GT_UMOD) and only the fixes for #117215 or #32615 to be more involved.
If we were to do one of the more involved fixes, I'd likely expect we universally apply this transform and then try to recognize and transform it back later on xarch if other optimizations didn't occur.
This was referenced Sep 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #119131