Add macOS 26 ("Tahoe") support to runtime-extra-platforms #118611
Conversation
Co-authored-by: bartonjs <[email protected]>
Copilot
AI
changed the title
|
@copilot The |
No changes are needed to
The macOS 26 support will activate automatically when |
|
/azp run runtime-extra-platforms |
|
Azure Pipelines failed to run 1 pipeline(s). |
|
The runtime-extra-platforms pipeline is cooked right now, so you probably want to wait for a working starting place. #118621 |
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for macOS 26 ("Tahoe") to the runtime-extra-platforms configuration by introducing OSX.26 queue support across multiple helix queue setup files. The implementation uses conditional logic to ensure OSX.26 queues are only used for extra platforms builds while maintaining existing behavior for main testing.
Key changes:
- Added OSX.26.Amd64.Open and OSX.26.Arm64.Open queue support for extra platforms builds
- Implemented conditional logic using
isExtraPlatformsBuildparameter to route to appropriate queues - Extended osx_arm64 platform support to runtime-extra-platforms-other.yml
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| eng/pipelines/libraries/helix-queues-setup.yml | Added OSX.26.Arm64.Open queue for osx_arm64 platform when isExtraPlatformsBuild=true |
| eng/pipelines/installer/helix-queues-setup.yml | Added OSX.26.Arm64.Open queue for osx_arm64 platform when isExtraPlatformsBuild=true |
| eng/pipelines/extra-platforms/runtime-extra-platforms-other.yml | Added osx_arm64 platform to the supported platforms list |
| eng/pipelines/coreclr/templates/helix-queues-setup.yml | Added OSX.26.Arm64.Open queue with updated conditional logic for extra platforms builds |
|
Do you need to triage new failures in https://dev.azure.com/dnceng-public/public/_build/results?buildId=1122699&view=logs&j=88ca5a82-aab9-5975-0034-f4bb53389110&t=1c1d8f93-f06c-530f-c1b3-3c5f79c29ff3&l=52 and file issues? |
The networking one looks like a normal network hiccup; and the others are already reported at https://github.com/dotnet/runtime/issues?q=state%3Aopen%20label%3A%22os-macos-tahoe%20(macOS26)%22 |
|
/ba-g Unknown failures seem to be DeadLetter queues, not part of this change. |
@bartonjs @jeffhandley - can you address this question? When we add a new platform like this in a non-blocking build pipeline, the work is not to just add the platform. It's to comb through all the test failures to see if there any new ones specific to that platform and file issues to investigate. If we don't do that, then any new failures will just get lost in all the other test failures that occur on that platform. What's our plan for understanding how we're doing on this new platform? |
I already did: #118611 (comment) |
|
Sorry I somehow missed that comment. I'm going to blame github rather than my eyesight. Thank you for having a look. LGTM |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
6 participants
This change adds support for macOS 26 ("Tahoe") to the runtime-extra-platforms configuration using the "OSX.26" queue base name as requested.
Changes Made
Added OSX.26 queue support to all helix queue setup files:
OSX.26.Amd64.Openfor x64 architectureOSX.26.Arm64.Openfor arm64 architectureThe OSX.26 queues are configured to be used only when
isExtraPlatformsBuild=true, ensuring that main testing continues to use the oldest supported macOS versions as intended.Files Modified
eng/pipelines/libraries/helix-queues-setup.ymleng/pipelines/coreclr/templates/helix-queues-setup.ymleng/pipelines/installer/helix-queues-setup.ymlImplementation Details
The implementation uses conditional logic to select the appropriate queues:
For Extra Platforms builds (
isExtraPlatformsBuild=true):For Main Testing (
isExtraPlatformsBuild=false):This maintains full backward compatibility while enabling macOS 26 testing specifically for runtime-extra-platforms builds.
Fixes #118610.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.