Move the implementation of Monitor to managed in CoreCLR #118371
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkotas
reviewed
Aug 8, 2025
src/coreclr/System.Private.CoreLib/src/System/Threading/SyncTable.CoreCLR.cs
Outdated
Show resolved
Hide resolved
1 task
This was referenced Aug 8, 2025
Open
jkotas
reviewed
Aug 15, 2025
…er once to avoid racing. Furthermore, handle an uninitialized lock ID in ObjectHeader.CoreCLR.cs. There's a possibility that the first time the managed Lock type's thread id tracking is used is on releasing a lock that was upgraded to a fat lock.
…inlock for thin->fat lock upgrading
jkotas
reviewed
Oct 27, 2025
src/coreclr/System.Private.CoreLib/src/System/Threading/Monitor.CoreCLR.cs
Show resolved
Hide resolved
jkotas
reviewed
Oct 27, 2025
src/coreclr/System.Private.CoreLib/src/System/Threading/Monitor.CoreCLR.cs
Outdated
Show resolved
Hide resolved
jkotas
reviewed
Oct 27, 2025
src/coreclr/System.Private.CoreLib/src/System/Threading/Monitor.CoreCLR.cs
Show resolved
Hide resolved
jkotas
reviewed
Oct 27, 2025
jkotas
reviewed
Oct 27, 2025
jkotas
reviewed
Oct 27, 2025
jkotas
reviewed
Oct 27, 2025
src/libraries/System.Private.CoreLib/src/System/Threading/ThreadBlockingInfo.cs
Outdated
Show resolved
Hide resolved
jkotas
reviewed
Oct 27, 2025
src/libraries/System.Private.CoreLib/src/ILLink/ILLink.Descriptors.Shared.xml
Show resolved
Hide resolved
|
Looks good to me otherwise! |
…gedThreadId definitions (the last place that differs between runtimes)
jkotas
reviewed
Oct 28, 2025
src/coreclr/System.Private.CoreLib/src/System/Threading/WaitHandle.CoreCLR.cs
Outdated
Show resolved
Hide resolved
src/coreclr/System.Private.CoreLib/src/System/Threading/Monitor.CoreCLR.cs
Outdated
Show resolved
Hide resolved
src/coreclr/System.Private.CoreLib/src/System/Threading/Monitor.CoreCLR.cs
Outdated
Show resolved
Hide resolved
src/coreclr/System.Private.CoreLib/src/System/Threading/Monitor.CoreCLR.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Private.CoreLib/src/System/Threading/Lock.cs
Outdated
Show resolved
Hide resolved
src/coreclr/nativeaot/System.Private.CoreLib/src/System/Threading/Lock.NativeAot.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Private.CoreLib/src/System/Threading/Lock.cs
Outdated
Show resolved
Hide resolved
jkotas
reviewed
Oct 29, 2025
src/coreclr/System.Private.CoreLib/src/System/Threading/SynchronizedMethodHelpers.CoreCLR.cs
Outdated
Show resolved
Hide resolved
jkotas
reviewed
Oct 29, 2025
This was referenced Oct 29, 2025
|
/ba-g WBT and deadletter unrelated. Sve failure tracked in #121189 |
rhuijben
reviewed
Oct 30, 2025
| // so we create an empty enumerator. | ||
| CordbBlockingObjectEnumerator* objEnum = new CordbBlockingObjectEnumerator( | ||
| GetProcess(), | ||
| new CorDebugBlockingObject[0], |
There was a problem hiding this comment.
No longer deleted at the end of the function. It is 0 bytes, but...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to share more code with NativeAOT, reduce a decent amount of complexity in the runtime, and fixes a blocking issue for #117788