-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Rename NDirect -> PInvoke #118228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename NDirect -> PInvoke #118228
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR renames "NDirect" terminology to "PInvoke" throughout the codebase to improve clarity and consistency. NDirect was an older term used internally to refer to Platform Invoke (P/Invoke) functionality for calling native code from managed code.
- Renames classes, methods, and variables from NDirect* to PInvoke*
- Updates comments and documentation to use PInvoke terminology
- Maintains the same functionality while improving code readability
Reviewed Changes
Copilot reviewed 93 out of 93 changed files in this pull request and generated 3 comments.
File | Description |
---|---|
Multiple .cpp/.h files | Rename NDirectMethodDesc to PInvokeMethodDesc and related methods |
Assembly files | Update function names from NDirectImportThunk to PInvokeImportThunk |
Header files | Rename class declarations and type definitions |
Documentation/comments | Update terminology from NDirect to PInvoke throughout |
src/libraries/System.Private.CoreLib/src/Resources/Strings.resx
Outdated
Show resolved
Hide resolved
...ged/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Contracts/PrecodeStubs_Common.cs
Outdated
Show resolved
Hide resolved
Tagging subscribers to this area: @mangod9 |
The codebase has been using mix of both names that just does not look great.
|
…er.Contracts/Contracts/PrecodeStubs_Common.cs Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
/cc @dotnet/dotnet-diag |
Failures are #118246 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No description provided.