JIT: Fix ARM64 emitter tests #117768
JIT: Fix ARM64 emitter tests #117768
Conversation
github-actions
bot
added
the
area-CodeGen-coreclr
There was a problem hiding this comment.
Pull Request Overview
This PR disables unit tests for unsupported SVE encodings and corrects incorrect branch conditions in the ARM64 SVE emitter.
- Wrap unsupported encoding tests in
codegenarm64test.cppwithALL_ARM64_EMITTER_UNIT_TESTS_SVE_UNSUPPORTEDguards. - Fix conditional checks in
emitarm64sve.cppto useINS_OPTS_SCALABLE_SandINS_OPTS_SCALABLE_Din the correct branches.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/coreclr/jit/emitarm64sve.cpp | Corrected conditional checks for INS_OPTS_SCALABLE_S/_D in SVE emitter format logic |
| src/coreclr/jit/codegenarm64test.cpp | Wrapped unsupported SVE encoding tests in #ifdef ALL_ARM64_EMITTER_UNIT_TESTS_SVE_UNSUPPORTED |
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
|
@dotnet/jit-contrib PTAL, thanks |
a74nh
left a comment
a74nh
left a comment
There was a problem hiding this comment.
This LGTM. Revert of a recent change plus some fixups.
|
ping @dotnet/jit-contrib |
a74nh
left a comment
a74nh
left a comment
There was a problem hiding this comment.
LGTM.
(Apologies thought I had already looked at this)
No worries, you approved it already. I just need approval from someone on the JIT team. @jakobbotsch could you PTAL? Thanks! |
|
/ba-g build timeouts |
|
/ba-g build timeouts |
3 participants
Follow-up to discussion in #117660. This disables tests for unsupported encodings, and fixes a few incorrect branches in the SVE emitter. cc @dotnet/arm64-contrib