[browser] Migrate WebAssemblyHotReloadCapabilities from Blazor to WasmSDK #117747
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maraf
added
arch-wasm
|
cc @tmat |
There was a problem hiding this comment.
Pull Request Overview
This PR migrates WebAssembly Hot Reload capabilities configuration from Blazor-specific settings to the broader WasmSDK, making Hot Reload functionality available for all WebAssembly browser scenarios. This change supports the introduction of a new HotReload package in the SDK that will be automatically referenced by WasmSDK.
Key changes:
- Moves .NET version detection logic to an earlier PropertyGroup for reuse
- Adds WebAssemblyHotReloadCapabilities property with framework-specific capability sets
- Removes duplicate version detection code from the _ResolveWasmConfiguration target
...nuget/Microsoft.NET.Sdk.WebAssembly.Pack/build/Microsoft.NET.Sdk.WebAssembly.Browser.targets
Show resolved
Hide resolved
|
Tagging subscribers to 'arch-wasm': @lewing |
javiercn
reviewed
Jul 17, 2025
...nuget/Microsoft.NET.Sdk.WebAssembly.Pack/build/Microsoft.NET.Sdk.WebAssembly.Browser.targets
Show resolved
Hide resolved
javiercn
approved these changes
Jul 17, 2025
Open
3 tasks
|
/ba-g Timeouts are covered in other architecture legs |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In dotnet/sdk#49800 we are introducing a HotReload package that will be automatically referenced by WasmSDK and usable for all WebAssembly in browser scenarios. We need to set HotReload capabilities in a common place.
In .NET 8+ the runtime capabilities are the same.
Manually tested that HotReload is able to pick the value after removing it from Blazor
Contributes to dotnet/aspnetcore#61272