Seal a few more extensions types with only a private ctor #117368
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR seals the NullLoggerProvider and NullChangeToken classes in both implementation and reference assemblies to prevent inheritance.
- Mark
NullLoggerProviderassealedin source and ref API. - Mark
NullChangeTokenassealedin source and ref API.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/libraries/Microsoft.Extensions.Logging.Abstractions/src/NullLoggerProvider.cs | Added sealed modifier to NullLoggerProvider. |
| src/libraries/Microsoft.Extensions.Logging.Abstractions/ref/Microsoft.Extensions.Logging.Abstractions.cs | Added sealed modifier to partial NullLoggerProvider. |
| src/libraries/Microsoft.Extensions.FileProviders.Abstractions/src/NullChangeToken.cs | Added sealed modifier to NullChangeToken. |
| src/libraries/Microsoft.Extensions.FileProviders.Abstractions/ref/Microsoft.Extensions.FileProviders.Abstractions.cs | Added sealed modifier to partial NullChangeToken. |
|
Tagging subscribers to this area: @dotnet/area-extensions-logging |
...s/Microsoft.Extensions.Logging.Abstractions/ref/Microsoft.Extensions.Logging.Abstractions.cs
Outdated
Show resolved
Hide resolved
...Extensions.FileProviders.Abstractions/ref/Microsoft.Extensions.FileProviders.Abstractions.cs
Outdated
Show resolved
Hide resolved
MihaZupan
approved these changes
Jul 7, 2025
Co-authored-by: Theodore Tsirpanis <[email protected]>
tarekgh
approved these changes
Jul 7, 2025
This was referenced Jul 7, 2025
|
/ba-g dead letter queue |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.