Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/design/mono/web/linear-ir.md
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ Each IR instruction is represented by a MonoInst structure. The fields of the st

- ins-\>opcode contains the opcode of the instruction. It is always set.

- ins-\>dreg, ins-\>sreg1, ins-\>sreg2 contain the the destination and source vregs of the instruction. If the instruction doesn't have a destination/and our source, the corresponding field is set to -1.
- ins-\>dreg, ins-\>sreg1, ins-\>sreg2 contain the destination and source vregs of the instruction. If the instruction doesn't have a destination/and our source, the corresponding field is set to -1.

- ins-\>backend is used for various purposes:
- for MonoInst's representing vtype variables, it indicates that the variable is in unmanaged format (used during marshalling)
Expand Down
2 changes: 1 addition & 1 deletion docs/design/mono/web/soft-debugger-wire-format.md
Original file line number Diff line number Diff line change
Expand Up @@ -392,7 +392,7 @@ Each command requires at least one TypeID (of type id) parameter before any addi
| GET_FIELD_CATTRS | 11 | Returns a list of custom attributes of a type's field. Custom attribute definition is given below. | Ask for a FieldID of one the type field and a TypeID of an custom attribute type | INVALID_TYPEID, INVALID_FIELDID |
| GET_PROPERTY_CATTRS | 12 | Returns a list of custom attributes of a type's property. Custom attribute definition is given below. | Ask for a PropertyID of one the type field and a TypeID of an custom attribute type | INVALID_TYPEID, INVALID_PROPERTYID |
| GET_SOURCE_FILES_2 | 13 | Returns a list of source file full paths (string) where the type is defined | None | INVALID_TYPEID |
| GET_VALUES_2 | 14 | Returns a number of variant value equals to the number of FieldID that was passed as parameter. If the field had a ThreadStatic attribute applied to it, value fetched are from the thread parameter point of view. | Ask for an ObjectID representing a System.Thread instance and a list of FieldID representing this type static fields to the the value of. Only static field are supported. | INVALID_OBJECT, INVALID_TYPEID, INVALID_FIELDID |
| GET_VALUES_2 | 14 | Returns a number of variant value equals to the number of FieldID that was passed as parameter. If the field had a ThreadStatic attribute applied to it, value fetched are from the thread parameter point of view. | Ask for an ObjectID representing a System.Thread instance and a list of FieldID representing this type static fields to the value of. Only static field are supported. | INVALID_OBJECT, INVALID_TYPEID, INVALID_FIELDID |

The main functions handling these commands are `type_commands` and `type_commands_internal` and are situated at `debugger-agent.c:6726` and `debugger-agent.c:6403` respectively.

Expand Down
2 changes: 1 addition & 1 deletion docs/design/security/System.HashCode.md
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ Concretely, in the face of adversarial input:

## Implementation

The `HashCode` type uses the [**xxHash32**](https://github.com/Cyan4973/xxHash) algorithm, which is a non-cryptographic hash algorithm with a 32-bit seed and a 32-bit digest. All instances of the `HashCode` type use the same seed value, generated randomly at app start. This value is chosen independently of other random seed values in the runtime, such as the the global 64-bit seed used in `string.GetHashCode`'s Marvin32 routine.
The `HashCode` type uses the [**xxHash32**](https://github.com/Cyan4973/xxHash) algorithm, which is a non-cryptographic hash algorithm with a 32-bit seed and a 32-bit digest. All instances of the `HashCode` type use the same seed value, generated randomly at app start. This value is chosen independently of other random seed values in the runtime, such as the global 64-bit seed used in `string.GetHashCode`'s Marvin32 routine.

The xxHash32 repo's README file touts good performance and avalanching. This can be validated through a simple C# program.

Expand Down
2 changes: 1 addition & 1 deletion docs/project/list-of-diagnostics.md
Original file line number Diff line number Diff line change
Expand Up @@ -296,7 +296,7 @@ The diagnostic id values reserved for .NET Libraries analyzer warnings are `SYSL
APIs can be marked as `[Experimental]` if their shape or functionality is included in a release but not yet officially supported. Experimental APIs offer the opportunity to collect customer feedback on these APIs in a major release, usually refining the APIs and removing the `[Experimental]` attribute in the next release. The `[Experimental]` attribute differs from `[RequiresPreviewFeatures]`, wherein:

* `[RequiresPreviewFeatures]` APIs require a corresponding preview feature in another product area such as the compiler or SDK
- Using these APIs requires enabling preview features for the the project and all its consumers
- Using these APIs requires enabling preview features for the project and all its consumers
* `[Experimental]` APIs are self-contained within the libraries and do not require preview features in other parts of the product
- These APIs can be used by suppressing specific diagnostics without enabling preview features for the project

Expand Down
2 changes: 1 addition & 1 deletion src/coreclr/jit/fgehopt.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -2505,7 +2505,7 @@ BasicBlock* Compiler::fgCloneTryRegion(BasicBlock* tryEntry, CloneTryInfo& info,
//
// We need to clone to the entire try region plus any
// enclosed regions and any enclosing mutual protect regions,
// plus all the the associated handlers and filters and any
// plus all the associated handlers and filters and any
// regions they enclose, plus any callfinallies that follow.
//
// This is necessary because try regions can't have multiple entries, or
Expand Down
2 changes: 1 addition & 1 deletion src/coreclr/jit/smallhash.h
Original file line number Diff line number Diff line change
Expand Up @@ -583,7 +583,7 @@ class HashTableBase

//------------------------------------------------------------------------
// HashTableBase::Remove: removes a key from the hash table and asserts
// that it did exist in the the table.
// that it did exist in the table.
//
// Arguments:
// key - The key to remove from the table.
Expand Down
2 changes: 1 addition & 1 deletion src/coreclr/tools/superpmi/superpmi/neardiffer.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -416,7 +416,7 @@ bool NearDiffer::mungeOffsets(
// We might want to do something similar for mov/movk/movk/movk sequences on Arm64. The following code was
// previously used, but currently is not active.
//
// One difference is we might see a different number of movk on arm64 depending on the the data. Our "hack"
// One difference is we might see a different number of movk on arm64 depending on the data. Our "hack"
// of zeroing out the constant so they compare equal doesn't work well. In this case, we really do want
// a callback to the disassembler to skip the instructions.
//
Expand Down
4 changes: 2 additions & 2 deletions src/coreclr/unwinder/arm64/unwinder.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1702,7 +1702,7 @@ Routine Description:
returned.

HandlerData - Supplies a pointer to a variable that receives a pointer
the the language handler data.
the language handler data.

UnwindParams - Additional parameters shared with caller.

Expand Down Expand Up @@ -2550,7 +2550,7 @@ Routine Description:
ContextRecord - Supplies the address of a context record.

HandlerData - Supplies a pointer to a variable that receives a pointer
the the language handler data.
the language handler data.

EstablisherFrame - Supplies a pointer to a variable that receives the
the establisher frame pointer value.
Expand Down
Loading