Composite ML-DSA + RSA Managed Composer #117259

PranavSenthilnathan · 2025-07-03T04:48:39Z

Add managed Composite ML-DSA implementation that uses the ML-DSA and RSA primitives to implement the composite algorithm. This works downlevel in Microsoft.Bcl.Cryptography as well.

Sign
Verify
Import raw key
Export raw key

Contributes to #116998

dotnet-policy-service · 2025-07-03T04:49:33Z

Tagging subscribers to this area: @dotnet/area-system-security, @bartonjs, @vcsjones
See info in area-owners.md if you want to be subscribed.

…dsa-managed

bartonjs

Posting review "between" code and tests

src/libraries/Common/src/System/Security/Cryptography/CompositeMLDsaAlgorithm.cs

src/libraries/Common/src/System/Security/Cryptography/CompositeMLDsa.cs

src/libraries/Common/src/System/Security/Cryptography/CompositeMLDsaMessageEncoder.cs

src/libraries/Common/src/System/Security/Cryptography/ManagedCompositeMLDsaComposer.cs

...ty/Cryptography/AlgorithmImplementations/CompositeMLDsa/CompositeMLDsaAlgorithmExtensions.cs

.../Security/Cryptography/AlgorithmImplementations/CompositeMLDsa/CompositeMLDsaFactoryTests.cs

...m/Security/Cryptography/AlgorithmImplementations/CompositeMLDsa/CompositeMLDsaTestHelpers.cs

src/libraries/Common/tests/System/Security/Cryptography/Helpers.cs

src/libraries/Common/src/System/Security/Cryptography/MLDsaImplementation.NotSupported.cs

...System.Security.Cryptography/src/System/Security/Cryptography/MLDsaImplementation.OpenSsl.cs

src/libraries/Common/src/System/Security/Cryptography/ManagedCompositeMLDsaComposer.cs

src/libraries/Common/src/System/Security/Cryptography/CompositeMLDsa.cs

bartonjs

I thought I'd get further than I did... but here's what I got so far.

src/libraries/Common/src/System/Security/Cryptography/CompositeMLDsaAlgorithm.cs

src/libraries/Common/src/System/Security/Cryptography/CompositeMLDsaManaged.cs

src/libraries/Common/src/System/Security/Cryptography/KeyBlobHelpers.cs

src/libraries/Common/src/System/Security/Cryptography/RSAKeyFormatHelper.cs

bartonjs

Posting between src and tests

src/libraries/Common/src/System/Security/Cryptography/CompositeMLDsa.cs

src/libraries/System.Security.Cryptography/src/Resources/Strings.resx

src/libraries/Common/src/System/Security/Cryptography/CompositeMLDsa.cs

src/libraries/Common/src/System/Security/Cryptography/CompositeMLDsaAlgorithm.cs

src/libraries/Common/src/System/Security/Cryptography/CompositeMLDsaManaged.RSA.cs

src/libraries/Common/src/System/Security/Cryptography/CompositeMLDsaManaged.cs

src/libraries/Common/src/System/Security/Cryptography/KeyBlobHelpers.cs

bartonjs

Also made it through the tests!

...Security/Cryptography/AlgorithmImplementations/CompositeMLDsa/CompositeMLDsaContractTests.cs

.../Security/Cryptography/AlgorithmImplementations/CompositeMLDsa/CompositeMLDsaFactoryTests.cs

.../Security/Cryptography/AlgorithmImplementations/CompositeMLDsa/CompositeMLDsaTestData.Raw.cs

...tem/Security/Cryptography/AlgorithmImplementations/CompositeMLDsa/CompositeMLDsaTestsBase.cs

src/libraries/Common/src/System/Security/Cryptography/CompositeMLDsa.cs

PranavSenthilnathan · 2025-07-18T18:02:00Z

/ba-g #117772

Neustradamus · 2025-07-20T09:41:50Z

@PranavSenthilnathan: Good job!

[WIP] Managed Composite ML-DSA Composer

2f47eb6

PranavSenthilnathan self-assigned this Jul 3, 2025

github-actions bot added the area-System.Security label Jul 3, 2025

PranavSenthilnathan added 2 commits July 2, 2025 22:06

Merge branch 'main' of https://github.com/dotnet/runtime into comp-ml…

479b624

…dsa-managed

Regenerate KATs and fix tests

6b755af

bartonjs requested changes Jul 7, 2025

View reviewed changes

bartonjs reviewed Jul 7, 2025

View reviewed changes

vcsjones reviewed Jul 7, 2025

View reviewed changes

src/libraries/Common/src/System/Security/Cryptography/ManagedCompositeMLDsaComposer.cs Outdated Show resolved Hide resolved

add netfx support for import and export

73373d3

PranavSenthilnathan added 4 commits July 9, 2025 12:17

get netfx build working

1db241d

refactoring

51dd9fc

Clean up

b8ca5f1

Add basic tests

2b98a39

This was referenced Jul 11, 2025

[QUIC & HTTP/3] Handshake Timeout on tests #104426

Closed

System.OperationCanceledException : The operation was canceled. dotnet/dnceng#5278

Closed

Unable to pull image from mcr.microsoft.com #117164

Open

PranavSenthilnathan added 2 commits July 11, 2025 11:50

More tests

fd0a125

Fix build

5ada8aa

This was referenced Jul 11, 2025

Tracking: Failed to find a suitable device for target tvos-device dotnet/dnceng#5179

Open

RuntimeBinder tests fail finding IsType method #117565

Closed

Even more tests

8747d30

Cleanup

8ba09a1

PranavSenthilnathan marked this pull request as ready for review July 14, 2025 17:05

PranavSenthilnathan changed the title ~~[WIP] Composite ML-DSA Managed Composer~~ Composite ML-DSA + RSA Managed Composer Jul 14, 2025

bartonjs reviewed Jul 15, 2025

View reviewed changes

src/libraries/Common/src/System/Security/Cryptography/CompositeMLDsa.cs Outdated Show resolved Hide resolved

bartonjs reviewed Jul 15, 2025

View reviewed changes

This was referenced Jul 15, 2025

The Operation will be canceled. The next steps may not contain expected logs. dotnet/dnceng#3008

Open

SendAsync_RequestWithDangerousControlHeaderValue_ThrowsHttpRequestException fails with QUIC protocol error #117198

Closed

PranavSenthilnathan commented Jul 15, 2025

View reviewed changes

src/libraries/Common/src/System/Security/Cryptography/CompositeMLDsaManaged.cs Show resolved Hide resolved

PranavSenthilnathan commented Jul 15, 2025

View reviewed changes

src/libraries/Common/src/System/Security/Cryptography/KeyBlobHelpers.cs Show resolved Hide resolved

PranavSenthilnathan commented Jul 15, 2025

View reviewed changes

src/libraries/Common/src/System/Security/Cryptography/RSAKeyFormatHelper.cs Show resolved Hide resolved

bartonjs reviewed Jul 15, 2025

View reviewed changes

bartonjs self-requested a review July 15, 2025 23:45

PranavSenthilnathan added 2 commits July 17, 2025 16:30

PR feedback

463b3ab

Stop depending on ArrayPool internal implementation

00595fe

bartonjs approved these changes Jul 17, 2025

View reviewed changes

xmldoc and CryptoPoolLease

7ac3a1d

bartonjs approved these changes Jul 18, 2025

View reviewed changes

PranavSenthilnathan and others added 2 commits July 17, 2025 17:21

Merge branch 'main' into comp-mldsa-managed

325954b

fix test: linux is not implemented

05744c5

build-analysis bot mentioned this pull request Jul 18, 2025

[WASM] Hundreds of tests failing without log #117772

Closed

PranavSenthilnathan merged commit d71abb0 into dotnet:main Jul 18, 2025
83 of 87 checks passed

PranavSenthilnathan deleted the comp-mldsa-managed branch July 18, 2025 18:02

PranavSenthilnathan mentioned this pull request Jul 20, 2025

KeyGen and OSSL support for managed Composite ML-DSA + RSA #117856

Merged

github-actions bot locked and limited conversation to collaborators Aug 20, 2025

Composite ML-DSA + RSA Managed Composer #117259

Composite ML-DSA + RSA Managed Composer #117259

Uh oh!

Conversation

PranavSenthilnathan commented Jul 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dotnet-policy-service bot commented Jul 3, 2025

Uh oh!

bartonjs left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bartonjs left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bartonjs left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bartonjs left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

PranavSenthilnathan commented Jul 18, 2025

Uh oh!

Uh oh!

Neustradamus commented Jul 20, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

PranavSenthilnathan commented Jul 3, 2025 •

edited

Loading