JIT: Refactor CSE candidate storage slightly #116009
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CSE candidates had separate storage for the first candidate and subsequent candidates. This introduces some awkwardness when adding the second candidate to the list. Refactor things so that the first candidate is stored inline in `CSEDsc` as a normal list entry.
github-actions
bot
added
the
area-CodeGen-coreclr
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
Member
Author
|
cc @dotnet/jit-contrib PTAL @AndyAyersMS |
Contributor
There was a problem hiding this comment.
Pull Request Overview
Refactor the storage of CSE candidates by replacing separate fields for the first occurrence (csdTree, csdStmt, csdBlock) with an inline tree statement list (csdTreeList).
- Replace pointer fields with a value struct for the tree statement list in CSEdsc.
- Update all references and iterations from direct csdTree access to csdTreeList.tslTree accordingly.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/coreclr/jit/optcse.h | Updated CSEdsc structure to store the first candidate inline. |
| src/coreclr/jit/optcse.cpp | Revised all accesses to use csdTreeList.tslTree and adjusted loops to iterate from the list head. |
AndyAyersMS
reviewed
May 27, 2025
AndyAyersMS
approved these changes
May 27, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CSE candidates had separate storage for the first candidate and subsequent candidates. This introduces some awkwardness when adding the second candidate to the list.
Refactor things so that the first candidate is stored inline in
CSEDscas a normal list entry.Best reviewed with whitespace turned off.