Skip to content

[browser] Preload dotnet.js #114534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Apr 19, 2025
Merged

[browser] Preload dotnet.js #114534

merged 9 commits into from
Apr 19, 2025

Conversation

maraf
Copy link
Member

@maraf maraf commented Apr 11, 2025 •
edited
Loading

  • Add StaticWebAsset endpoint properties for preloading dotnet.js.
  • Wasm.Build.Tests test that preloading build logic picks the right endpoint.

Contributes to dotnet/aspnetcore#58875

@maraf maraf added arch-wasm WebAssembly architecture area-Build-mono os-browser Browser variant of arch-wasm labels Apr 11, 2025
@maraf maraf added this to the 10.0.0 milestone Apr 11, 2025
@maraf maraf self-assigned this Apr 11, 2025
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

@build-analysis build-analysis bot mentioned this pull request Apr 11, 2025
Closed
@maraf maraf changed the title [browser] Define which assets to preload [browser] Preload dotnet.js Apr 17, 2025
@maraf maraf marked this pull request as ready for review April 17, 2025 16:57
@Copilot Copilot AI review requested due to automatic review settings April 17, 2025 16:57
@maraf maraf requested a review from pavelsavara April 17, 2025 16:57
Copilot
Copilot AI reviewed Apr 17, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.

Files not reviewed (1)
  • src/mono/nuget/Microsoft.NET.Sdk.WebAssembly.Pack/build/Microsoft.NET.Sdk.WebAssembly.Browser.targets: Language not supported
Comments suppressed due to low confidence (1)

src/mono/wasm/testassets/WasmBasicTestApp/App/wwwroot/index.html:10

  • [nitpick] The id 'webassembly' is somewhat ambiguous given the PR's intent to preload dotnet.js. Consider renaming it to something like 'dotnet-preload' for clearer intent.
<link rel="preload" id="webassembly" />

@build-analysis build-analysis bot mentioned this pull request Apr 17, 2025
Open
3 tasks
@maraf maraf merged commit 50c020e into dotnet:main Apr 19, 2025
24 of 26 checks passed
@maraf maraf deleted the BrowserPreload branch April 19, 2025 10:59
This was referenced Apr 19, 2025
Closed
Open
@maraf maraf mentioned this pull request Apr 22, 2025
Closed
@github-actions github-actions bot locked and limited conversation to collaborators May 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

Copilot code review Copilot Copilot left review comments

@akoeplinger akoeplinger akoeplinger approved these changes

@ilonatommy ilonatommy Awaiting requested review from ilonatommy ilonatommy is a code owner

@lewing lewing Awaiting requested review from lewing lewing is a code owner

@pavelsavara pavelsavara Awaiting requested review from pavelsavara

Assignees

@maraf maraf

Labels

arch-wasm WebAssembly architecture area-Build-mono os-browser Browser variant of arch-wasm

Projects

None yet

Milestone

10.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@maraf @akoeplinger