Remove CopyFile, GetTempFileName from PAL #113490
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
dotnet-policy-service
bot
added
the
community-contribution
huoyaoyuan
commented
Mar 13, 2025
| return E_FAIL; | ||
| } | ||
| #else // TARGET_WINDOWS | ||
| assert(!copyJit); |
Member
Author
There was a problem hiding this comment.
copyJit is always passed as false. Even if we do use it in the future, std::filesystem::copy should be better alternative.
Member
There was a problem hiding this comment.
Delete the copyJit argument since it is unused?
Open
3 tasks
Member
Author
|
Failure looks unrelated. Helix sends Not Found for the console log. |
3 tasks
jkotas
reviewed
Mar 14, 2025
|
|
||
| bool JitInstance::reLoad(MethodContext* firstContext) | ||
| { | ||
| FreeLibrary(hLib); |
Member
There was a problem hiding this comment.
JitInstance::reLoad looks like a dead code and it can be deleted. Once you do that, PathToOriginalJit field becomes unused and it can be deleted too.
Member
Author
There was a problem hiding this comment.
@dotnet/jit-contrib Any comment on the functionality of superpmi?
Contributor
There was a problem hiding this comment.
As stated, reLoad can be deleted since it is dead code.
BruceForstall
approved these changes
Mar 18, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.