Skip to content

Conversation

@tarekgh
Copy link
Member

@tarekgh tarekgh commented Jan 23, 2025

Fixes #111689

@ghost ghost added the area-System.DateTime label Jan 23, 2025
@tarekgh tarekgh added this to the 10.0.0 milestone Jan 23, 2025
@tarekgh tarekgh requested a review from Copilot January 23, 2025 00:19
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

src/libraries/System.Runtime/tests/System.Runtime.Tests/System/DateTimeTests.cs:2698

  • The test should verify both the date and time parts of the parsed DateTime to ensure it is correctly parsed and in UTC. Consider adding assertions to check the time part as well.
Assert.True(utcNow1.Date <= dt.Date && dt.Date <= utcNow2.Date);

@tarekgh
Copy link
Member Author

tarekgh commented Jan 23, 2025

/ba-g no real failure is reported

@tarekgh tarekgh merged commit f196875 into dotnet:main Jan 23, 2025
139 of 141 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Feb 23, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DateTime.Parse uses Local instead of UTC timestamp for time-only strings with DateTimeStyle.AssumeUniversal

2 participants