Skip to content

JIT: Move profile consistency checks to after loop opts #111285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Jan 21, 2025
Merged

JIT: Move profile consistency checks to after loop opts #111285

merged 14 commits into from
Jan 21, 2025

Conversation

@amanasifkhalid
Copy link
Contributor

Part of #107749.

@ghost ghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jan 10, 2025
@amanasifkhalid amanasifkhalid mentioned this pull request Jan 10, 2025
Closed
45 tasks
@dotnet-policy-service
Copy link
Contributor

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

@build-analysis build-analysis bot mentioned this pull request Jan 11, 2025
Closed
@amanasifkhalid
Copy link
Contributor Author

/azp run runtime-coreclr libraries-jitstress, runtime-coreclr libraries-pgo

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@amanasifkhalid amanasifkhalid changed the title JIT: Move profile consistency checks to after loop recognition JIT: Move profile consistency checks to after loop opts Jan 15, 2025
@amanasifkhalid
Copy link
Contributor Author

/azp run runtime-coreclr libraries-jitstress, runtime-coreclr libraries-pgo

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

This was referenced Jan 15, 2025
Open
Open
@amanasifkhalid amanasifkhalid marked this pull request as ready for review January 16, 2025 02:05
@amanasifkhalid
Copy link
Contributor Author

cc @dotnet/jit-contrib, @AndyAyersMS PTAL. Diffs. libraries-pgo and libraries-jitstress runs from the previous build didn't hit any profile-related asserts. Thanks!

@amanasifkhalid
Copy link
Contributor Author

Updated diffs.

@amanasifkhalid
Copy link
Contributor Author

/azp run runtime-coreclr libraries-pgo

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@amanasifkhalid
Copy link
Contributor Author

libraries-pgo failures are #111347 and #111345.

@amanasifkhalid amanasifkhalid merged commit ccc9c52 into dotnet:main Jan 21, 2025
106 of 116 checks passed
@amanasifkhalid amanasifkhalid deleted the profile-checks-loop-finding branch January 21, 2025 20:27
@LoopedBard3 LoopedBard3 mentioned this pull request Jan 28, 2025
Closed
This was referenced Jan 28, 2025
Closed
Closed
Closed
Closed
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Feb 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@AndyAyersMS AndyAyersMS AndyAyersMS approved these changes

Assignees

@amanasifkhalid amanasifkhalid

Labels

area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@amanasifkhalid @AndyAyersMS