delete deadcode from nsutilpriv.h #108104
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
dotnet-policy-service
bot
added
the
community-contribution
Contributor
|
Tagging subscribers to this area: @mangod9 |
jkotas
reviewed
Sep 21, 2024
| // Concatenate type names to assembly names | ||
| //***************************************************************************** | ||
| static | ||
| bool MakeAssemblyQualifiedName( // true if ok, false if out of memory |
Member
There was a problem hiding this comment.
MakeAssemblyQualifiedName methods look like dead code. Could you please delete them instead?
jkotas
reviewed
Sep 22, 2024
| int dwAssemblyName); // Number of characters (not including null) | ||
|
|
||
| static | ||
| int MakeNestedTypeName( // true ok, false out of memory |
Contributor
Author
There was a problem hiding this comment.
only third one with stack string is in use
jkotas
reviewed
Sep 22, 2024
| // Concatinate type names to assembly names | ||
| //***************************************************************************** | ||
| static | ||
| bool MakeAssemblyQualifiedName( // true if ok, false if out of memory |
Member
There was a problem hiding this comment.
Also delete the implementation in https://github.com/dotnet/runtime/blob/main/src/coreclr/utilcode/namespaceutil.cpp
3 tasks
kasperk81
force-pushed
the
patch-5
branch
4 times, most recently
from
255b288 to
47c3cfb
Compare
jkotas
reviewed
Sep 22, 2024
src/coreclr/inc/nsutilpriv.h
Outdated
Comment on lines
153
to
156
| #ifdef _PREFAST_ | ||
| // need to set ptr=NULL so we don't get a build error because ptr isn't inited in a couple cases | ||
| #define MAKE_FULLY_QUALIFIED_MEMBER_NAME(ptr, pszNameSpace, pszClassName, pszMemberName, pszSig) ptr=NULL; | ||
| #else //_PREFAST_ |
Member
There was a problem hiding this comment.
Suggested change
| #ifdef _PREFAST_ | |
| // need to set ptr=NULL so we don't get a build error because ptr isn't inited in a couple cases | |
| #define MAKE_FULLY_QUALIFIED_MEMBER_NAME(ptr, pszNameSpace, pszClassName, pszMemberName, pszSig) ptr=NULL; | |
| #else //_PREFAST_ |
This should not be needed.
jkotas
reviewed
Sep 22, 2024
src/coreclr/inc/nsutilpriv.h
Outdated
| int __i##ptr = ns::GetFullLength(pszNameSpace, pszClassName); \ | ||
| __i##ptr += (pszMemberName ? (int) strlen(pszMemberName) : 0); \ | ||
| __i##ptr += (NAMESPACE_SEPARATOR_LEN * 2); \ | ||
| __i##ptr += (int)strlen(NAMESPACE_SEPARATOR_STR) + 1; \ |
Member
There was a problem hiding this comment.
This change does not look right. The code below adds NAMESPACE_SEPARATOR_STR up to two times, so it makes sense that NAMESPACE_SEPARATOR_LEN was multiplied by two.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.