JIT: Extend USEASG liveness to cover partial writes to retbufs #105996
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Liveness will add uses for explicit USEASG local stores that are not dead, but not for similar stores to locals via calls. Extend the coverage to calls. Fixes dotnet#105667.
ghost
added
the
area-CodeGen-coreclr
Member
Author
|
@jakobbotsch PTAL More surgical fix than in #105921 (which we may still consider, for .NET 10). No diffs seen locally for win x64. |
This was referenced Aug 6, 2024
jakobbotsch
approved these changes
Aug 6, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Liveness will add uses for explicit USEASG local stores that are not dead, but not for similar stores to locals via calls.
Extend the coverage to calls.
Fixes #105667.