Apply IDE0300 to corelib (use collection expressions instead of new[]) #105122

stephentoub · 2024-07-19T01:51:07Z

No description provided.

dotnet-policy-service · 2024-07-19T01:52:06Z

Tagging subscribers to this area: @dotnet/area-meta
See info in area-owners.md if you want to be subscribed.

tannergooding

This means many of these become stackallocs and now use the params ROSpan<T> overloads, correct?

src/libraries/System.Private.CoreLib/src/System/Globalization/CultureData.Nls.cs

src/libraries/System.Private.CoreLib/src/System/Globalization/CultureData.cs

src/libraries/System.Private.CoreLib/src/System/Globalization/OrdinalCasing.Icu.cs

src/libraries/System.Private.CoreLib/src/System/IO/Path.Windows.cs

src/libraries/System.Private.CoreLib/src/System/Threading/ThreadPoolWorkQueue.cs

stephentoub · 2024-07-19T13:00:22Z

This means many of these become stackallocs and now use the params ROSpan overloads, correct?

For this particular round of changes, most if not all of the cases I converted were target typed to T[], so the collection expressions are still forced to produce an array. However, for any where the target type was instead span, or where it is an argument to a method that has an overload that takes a span instead, then the compiler will do better, either using stack allocation or using assembly data if all elements were constant and the target is read only.

stephentoub · 2024-07-19T15:42:44Z

/ba-g unknown failure was a wasi leg not running a test

Apply IDE0300 to corelib (use collection expressions instead of new[])

954eb2b

ghost added the area-Meta label Jul 19, 2024

dotnet-policy-service bot assigned stephentoub Jul 19, 2024

tannergooding approved these changes Jul 19, 2024

View reviewed changes