Skip calling not implemented PEAssembly::GetDisplayName in DAC #104326
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
Contributor
|
Tagging subscribers to this area: @tommcdon |
jkotas
reviewed
Jul 2, 2024
| else if (name) | ||
| name[count-1] = 0; | ||
| } | ||
| else if (!pAssembly->GetPEAssembly()->IsReflectionEmit()) |
Member
There was a problem hiding this comment.
Is this DAC API used by anything? It does the same thing as GetAssemblyLocation, just the error handling is a bit different and it does not actually return assembly name as its name says.
IIRC, this API was originally part of an intern project that never shipped.
Member
Author
There was a problem hiding this comment.
It looks like SOS and clrmd use this (and not GetAssemblyLocation) when getting/showing information about an assembly/module or as a fallback when getting the name for a metadata token if it can't go through IMetaDataImport.
jkotas
approved these changes
Jul 2, 2024
Member
|
Thanks |
mikem8361
approved these changes
Jul 2, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PEAssembly::GetDisplayNamejust throws E_NOTIMPL in the DAC. Just make the current callers directly return E_NOTIMPL.cc @dotnet/dotnet-diag @lambdageek