-
Notifications
You must be signed in to change notification settings - Fork 5.3k
Arm AdvSimd: Rename LoadVector128xN to LoadNxVector128 #103626
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Note regarding the |
1 similar comment
|
Note regarding the |
|
Tagging subscribers to this area: @dotnet/area-system-runtime-intrinsics |
b07ebdb to
a0af045
Compare
|
Manually confirmed This is ready now. The mono parts haven't been tested as I don't know that code or how to test it, so needs a review from the mono team. @kunalspathak @dotnet/arm64-contrib |
fanyang-mono
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change to Mono looks good to me.
kunalspathak
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
coreclr changes LGTM. Thank you for doing this at short notice @a74nh!
|
@fanyang-mono - which CI pipelines we should run to make sure that the code in the PR is getting tested for mono? |
|
@kunalspathak There isn't a CI line currently could validate this change. I could run the tests locally. |
sounds good. Please confirm here once you do that and I will go ahead and merge it. |
|
Tests belonging to |
|
/ba-g timeout issues |
Partially fixes #102340