[release/8.0-staging] Fix a bug in PAL version of _vsnprint_f #103003
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the formatted string cannot fully fit in the buffer (including its null terminator) `_vsnprint_f` should return -1. However, in the case where the number of chars was the same as the buffer size it was returning the buffer size.
ghost
added
the
janvorli
approved these changes
Jun 3, 2024
|
Servicing approved via e-mail. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #98687 to release/8.0-staging
/cc @brianrob @jakobbotsch
Customer Impact
Found by internal profiler developers. This causes incorrect symbols to be displayed in profiles captured on Linux because the symbols are truncated in the
perf-%pid.mapfiles generated by CoreCLR. Full details of how to repro are available in #102938.Regression
The regression was introduced via #81243.
Testing
Fix was verified by cherry-picking this change locally and confirming that symbols are no longer truncated using a simple local repro.
Risk
Low. This is an off-by-one change that addresses when the full string cannot fit in the existing buffer.