Crash in GlobalizationNative_GetSortHandle related to System.Globalization.GlobalizationMode

[radekdoulik]

Context: dotnet/android#5669

In above PR we are experiencing crash in GlobalizationNative_GetSortHandle function. I found out that it happens only in trimmed apps. After further investigation, it can be worked around by preserving System.Globalization.GlobalizationMode type.

It might be related to these recent changes: #47999, dotnet/android@9ac280c

The workaround: dotnet/android@438afbb

Tagging subscribers to this area: @tarekgh, @safern
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Context: dotnet/android#5669

In above PR we are experiencing crash in GlobalizationNative_GetSortHandle function. I found out that it happens only in trimmed apps. After further investigation, it can be worked around by preserving System.Globalization.GlobalizationMode type.

It might be related to these recent changes: #47999, dotnet/android@9ac280c

The workaround: dotnet/android@438afbb

Author:	radekdoulik
Assignees:	-
Labels:	area-System.Globalization, untriaged
Milestone:	-

[safern]

cc: @eerhardt @marek-safar

Tagging subscribers to 'linkable-framework': @eerhardt, @vitek-karas, @LakshanF, @tannergooding, @sbomer
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Context: dotnet/android#5669

In above PR we are experiencing crash in GlobalizationNative_GetSortHandle function. I found out that it happens only in trimmed apps. After further investigation, it can be worked around by preserving System.Globalization.GlobalizationMode type.

It might be related to these recent changes: #47999, dotnet/android@9ac280c

The workaround: dotnet/android@438afbb

Author:	radekdoulik
Assignees:	-
Labels:	area-System.Globalization, linkable-framework, os-android
Milestone:	6.0.0

[eerhardt]

Just guessing by looking at the code, but is anything explicitly loading ICU on the xamarin android app?

What could be happening is the following line getting trimmed away:

runtime/src/libraries/System.Private.CoreLib/src/System/Globalization/GlobalizationMode.Unix.cs

Line 25 in a43deba

int loaded = Interop.Globalization.LoadICU();

And nothing else is loading ICU. So the ucol_open is NULL:

runtime/src/libraries/Native/Unix/System.Globalization.Native/pal_collation.c

Line 416 in 79ae74f

(*ppSortHandle)->collatorsPerOption[0] = ucol_open(lpLocaleName, &err);

[tarekgh]

@eerhardt is it possible to trim the line you pointed at even Invariant mode is off?

[eerhardt]

My assumption is that LoadICU() line is getting trimmed because I changed Xamarin apps to explicitly set <InvariantGlobalization>false</InvariantGlobalization>. That feature switch rewrites the method that calls into this line to just return false; all the time. Thus, this line isn't getting called anymore.

[eerhardt]

I can repro this outside of Xamarin, just on a plain linux machine using the latest SDK.

<Project Sdk="Microsoft.NET.Sdk">

  <PropertyGroup>
    <OutputType>Exe</OutputType>
    <TargetFramework>net6.0</TargetFramework>
    <InvariantGlobalization>false</InvariantGlobalization>
  </PropertyGroup>

</Project>

using System;
using System.Configuration;

namespace ConsoleApp7
{
    class Program
    {
        static void Main(string[] args)
        {
            Console.WriteLine(DateTime.Now);
        }
    }
}

$ dotnet publish -c Release -r linux-x64 -p:PublishTrimmed=true -p:TrimMode=link
$ ./bin/Release/net6.0/linux-x64/publish/ConsoleApp7
Segmentation fault (core dumped)