Skip to content

Rename WasmPerfTracing MSBuild property - linking mono diagnostic server #115473

@danroth27

Description

@danroth27

Looks like we shortened "Performance" to "Perf" in several identifiers in the new Blazor WebAssembly diagnostics support:

The .NET naming guidelines say that we should avoid abbreviations in identifiers, so I think these should technically be updated from "Perf" to "Performance".

WasmPerfTracing means include diagnostic server in the binaries. diagnostic server implements event pipe protocol. There are 3 (out of 4) major features that we support with it. 1) CPU sampling, 2) GC heap dump and 3) metrics. 4) We do not support dump of linear memory because there are no tools that would be able to display it.

  • There is EnableProfiler for the same thing for Android/iOS in in Net10.
  • @pavelsavara suggested WasmEnableEventPipe
  • @javiercn suggested WasmEnablePerformanceTracing
  • @jkotas metioned that NAOT enables it with EventSourceSupport
  • @akoeplinger suggested EnableDiagnosticsTracing or EnableDiagnostics

WasmPerformanceInstrumentation looks like good name for the second one. The feature is wasm specific and it needs to be separate from the other one because has significant negative performance impact and also non-trivial callspec for values.

Rename

  • WasmPerfTracing MSBuild property to EnableDiagnostics
  • WasmPerfInstrumentation MSBuild property to WasmPerformanceInstrumentation

Metadata

Metadata

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions