Skip to content

Update our LanguageServer OmniSharp lib package version. #1488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 14, 2020
Merged

Update our LanguageServer OmniSharp lib package version. #1488

merged 1 commit into from
Jan 14, 2020

Conversation

NTaylorMullen
Copy link

Update our LanguageServer OmniSharp lib package version.
e907eb3 
- Consuming several quality of life changes from O#. Such as support multiple languages in file paths.
- This also prepares us to take the TextDocumentSynchronization fixes started here: OmniSharp/csharp-language-server-protocol#199
ryanbrandenburg
ryanbrandenburg approved these changes Jan 13, 2020
View reviewed changes
Copy link
Contributor

@ryanbrandenburg ryanbrandenburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems super straightforward. Just curious, do we know what prompted them to do the namespace change?

@NTaylorMullen
Copy link
Author

Seems super straightforward. Just curious, do we know what prompted them to do the namespace change?

They were embedding a third party library due to strong name requirements for a while I believe. Now that third party library is in compliance with what they need so they no longer need to embed it I believe

@NTaylorMullen NTaylorMullen merged commit 0b748ca into master Jan 14, 2020
@NTaylorMullen NTaylorMullen deleted the nimullen/updatelsplib branch January 14, 2020 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ajaybhargavb ajaybhargavb Awaiting requested review from ajaybhargavb

@dougbu dougbu Awaiting requested review from dougbu

@rynowak rynowak Awaiting requested review from rynowak

1 more reviewer

@ryanbrandenburg ryanbrandenburg ryanbrandenburg approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@NTaylorMullen @ryanbrandenburg