-
Notifications
You must be signed in to change notification settings - Fork 285
Added serializing object property to JSON #936
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added serializing object property to JSON #936
Conversation
src/benchmarks/micro/corefx/System.Text.Json/Serializer/WriteJson.cs
Outdated
Show resolved
Hide resolved
adamsitnik
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
ahsonkhan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
|
With your fix from https://github.com/dotnet/corefx/issues/41638, is the performance of |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@ahsonkhan There is still some gap, though considering that But I haven't looked further into it, so it's possible there are still other optimizations to be had. |
Related to dotnet/corefx#41753 and https://github.com/dotnet/corefx/issues/41638.
This is a case where System.Text.Json currently has a performance issue, so I think it makes sense to add a benchmark for it, independently of whether the PR dotnet/corefx#41753 is accepted into corefx.