Supporting changes to implement python pipeline for performance runs on runtime repo #4156

caaavik-msft · 2024-04-16T20:44:19Z

This change needs to go in first before the changes to the runtime repository, however the changes do go hand-in-hand. These are all the changes needed to implement the python pipeline support on the runtime repo: dotnet/runtime#101143

scripts/run_performance_job.py

scripts/send_to_helix.py

eng/performance/helix.proj

scripts/run_performance_job.py

LoopedBard3

This is looking good, will approve once my few questions are answered or fixed.

LoopedBard3

Seems to look good, presuming successful test runs.

scripts/run_performance_job.py

DrewScoggins

Left a few comments, but they are pretty small.

caaavik-msft added 12 commits March 8, 2024 05:08

Make changes to python pipeline for runtime repo

675409e

More fixes

a99de98

Clean up some parts

e0f9132

Merge branch 'main' into caaavik/python-pipeline-for-runtime

6f5cc5a

Add latest changes from runtime repo

bfc50f1

Fix wasm bundle path and add arg support for local commit time

5b9f5d7

Fix local commit time code

0e43842

Only set core_root for coreclr runs

4df7faf

Fix ios hello world copying

75c1a48

Fix wasm copying and prereq check on linux

d4b116f

Fix wasm args quoting and PreparePayloadWorkItems usage

fd90221

Merge branch 'main' into caaavik/python-pipeline-for-runtime

e2ea387

caaavik-msft mentioned this pull request Apr 16, 2024

[PERF] Move performance testing logic into python scripts dotnet/runtime#101143

Merged

build-analysis bot mentioned this pull request Apr 16, 2024

RestApiException`1: The response contained an invalid status code 500 Internal Server Error dotnet/dnceng#2298

Open

3 tasks

LoopedBard3 reviewed Apr 18, 2024

View reviewed changes

scripts/run_performance_job.py Show resolved Hide resolved

LoopedBard3 reviewed Apr 18, 2024

View reviewed changes

scripts/send_to_helix.py Outdated Show resolved Hide resolved

caaavik-msft added 10 commits July 21, 2024 09:14

Merge branch 'main' into caaavik/python-pipeline-for-runtime

d158e8b

Merge branch 'main' into caaavik/python-pipeline-for-runtime

6c68491

Use new browser versions path

da1ad30

Fix prerequisites script building

5f16a3a

Fix wasm args building

3f393bc

Fix directory creation and prevent pip reinstalls

fa5345c

Fix trailing space on wasm args

f44f241

More various fixes

017204e

Fix file copy into root

cd5fdb2

Fix FailOnTestFailure value

8bb2497

caaavik-msft marked this pull request as ready for review July 23, 2024 10:52

caaavik-msft requested a review from DrewScoggins July 23, 2024 11:10

LoopedBard3 reviewed Jul 23, 2024

View reviewed changes

eng/performance/helix.proj Show resolved Hide resolved

scripts/run_performance_job.py Outdated Show resolved Hide resolved

LoopedBard3 reviewed Jul 24, 2024

View reviewed changes

scripts/run_performance_job.py Outdated Show resolved Hide resolved

LoopedBard3 reviewed Jul 24, 2024

View reviewed changes

caaavik-msft added 11 commits August 2, 2024 10:23

Merge branch 'main' into caaavik/python-pipeline-for-runtime

d5cdb7a

Merge branch 'main' into caaavik/python-pipeline-for-runtime

88df1c1

Include recent changes from runtime repo

2fc8c94

Only build startup and SOD for runtime scenarios

41ec18e

Fix infinite loop in zip creation

a8b43bb

Fix some directory issues

d79455a

Fix some copytree logic

3ea8dd3

Copy ios apps into correct dir

d9dcf41

Fix iosSampleApp copying + add better logging

98f2a60

Fix PDN download and error code

9e69d14

Address PR comments

38333a3

LoopedBard3 previously approved these changes Sep 10, 2024

View reviewed changes

Fix incorrect tfm condition check

dff7fec

caaavik-msft dismissed LoopedBard3’s stale review via dff7fec September 11, 2024 03:58

DrewScoggins reviewed Sep 13, 2024

View reviewed changes

scripts/run_performance_job.py Show resolved Hide resolved

DrewScoggins reviewed Sep 13, 2024

View reviewed changes

scripts/run_performance_job.py Outdated Show resolved Hide resolved

DrewScoggins reviewed Sep 13, 2024

View reviewed changes

scripts/run_performance_job.py Outdated Show resolved Hide resolved

DrewScoggins previously approved these changes Sep 13, 2024

View reviewed changes

Address PR comments

a4a0d97

caaavik-msft dismissed DrewScoggins’s stale review via a4a0d97 September 13, 2024 20:36

DrewScoggins approved these changes Sep 16, 2024

View reviewed changes

caaavik-msft merged commit 254b737 into dotnet:main Sep 16, 2024
50 of 57 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Supporting changes to implement python pipeline for performance runs on runtime repo #4156

Supporting changes to implement python pipeline for performance runs on runtime repo #4156

Uh oh!

caaavik-msft commented Apr 16, 2024 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

LoopedBard3 left a comment

Uh oh!

LoopedBard3 left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

DrewScoggins left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Supporting changes to implement python pipeline for performance runs on runtime repo #4156

Supporting changes to implement python pipeline for performance runs on runtime repo #4156

Uh oh!

Conversation

caaavik-msft commented Apr 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

LoopedBard3 left a comment

Choose a reason for hiding this comment

Uh oh!

LoopedBard3 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

DrewScoggins left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

caaavik-msft commented Apr 16, 2024 •

edited

Loading