-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Fix indentation of multiline messages in Terminal Logger. #9997
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
AR-May
merged 2 commits into
dotnet:main
from
AR-May:fix-multy-line-msg-quiet-verbosity
Apr 18, 2024
Merged
Fix indentation of multiline messages in Terminal Logger. #9997
AR-May
merged 2 commits into
dotnet:main
from
AR-May:fix-multy-line-msg-quiet-verbosity
Apr 18, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
21f9709 to
6cdc160
Compare
MichalPavlik
approved these changes
Apr 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall
JanKrivanek
reviewed
Apr 13, 2024
JanKrivanek
approved these changes
Apr 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
This was referenced Jul 28, 2025
Closed
Closed
This was referenced Aug 4, 2025
Closed
Closed
This was referenced Aug 15, 2025
Open
This was referenced Aug 25, 2025
Closed
This was referenced Oct 15, 2025
Closed
Open
This was referenced Oct 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9996
Context
The multiline messages indentation processing implies that the message will appear in the structured view under the related project. That is not correct for the Quiet verbosity and for couple of other places, such as rendering the immediate message and cases when the project is not determined.
Changes Made
Make the indentation dependent on where the message would be shown.
Testing
Unit tests