Skip to content

Conversation

@AR-May
Copy link
Member

@AR-May AR-May commented Apr 11, 2024

Fixes #9996

Context

The multiline messages indentation processing implies that the message will appear in the structured view under the related project. That is not correct for the Quiet verbosity and for couple of other places, such as rendering the immediate message and cases when the project is not determined.

Changes Made

Make the indentation dependent on where the message would be shown.

Testing

Unit tests

@AR-May AR-May force-pushed the fix-multy-line-msg-quiet-verbosity branch from 21f9709 to 6cdc160 Compare April 11, 2024 12:12
@AR-May AR-May requested a review from MichalPavlik April 11, 2024 12:14
Copy link
Member

@MichalPavlik MichalPavlik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall

Copy link
Member

@JanKrivanek JanKrivanek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@AR-May AR-May merged commit dcaa0bb into dotnet:main Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix indentation of multiline messages in Terminal Logger with quiet verbosity.

3 participants