Fix enum member name in resource string #7105
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `ProjectLoadSettings` enum does not contain a member named `RecordDuplicateImports`. This string appears to be referring to the `RecordDuplicateButNotCircularImports` member. I've updated the XLF files manually to avoid a loc pass.
There was a problem hiding this comment.
Looks like it was renamed in 2009: https://vstfdevdiv/DevDiv/Dev10/_versionControl/changeset/1157109/ (Microsoft-internal link).
@jonfortescue do you know if this string change will be worse for OneLocBuild than letting it go through the usual motions?
|
Hm, that's a good question. I think it should probably be fine? @cristianosuzuki77 to make sure I'm right on that. |
|
@cristianosuzuki77, got an opinion on making manual edits to the translated strings in cases where it's straightforward like this? |
Forgind
approved these changes
Jan 10, 2022
This was referenced Jul 29, 2025
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
While writing a unit test I hit this exception and found the error message slightly misleading.
The
ProjectLoadSettingsenum does not contain a member namedRecordDuplicateImports. This string appears to be referring to theRecordDuplicateButNotCircularImportsmember.Changes Made
Changed the content of the resource string.
Testing
CI.
Notes
I've updated the XLF files manually to avoid a loc pass. Please verify that this is safe to do, and that the loc team doesn't have a shadow copy of these strings somewhere else that is considered the source of truth.