Skip to content

use collection expressions in (non-test) sources #10758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Oct 8, 2024
Merged

use collection expressions in (non-test) sources #10758

merged 7 commits into from
Oct 8, 2024

Conversation

@kasperk81
Copy link
Contributor

few places were missing the modern syntax. excluding tests.

@rainersigwald
Copy link
Member

All automated refactoring or did you do anything manually? (assessing risk here :))

rainersigwald
rainersigwald reviewed Oct 4, 2024
View reviewed changes
Copy link
Member

@rainersigwald rainersigwald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Loving it!

@kasperk81
Copy link
Contributor Author

All automated refactoring or did you do anything manually? (assessing risk here :))

all manual git grep -ln 'new\s*\w*\[\]' | grep -vi test, updated them by hand and then ran the build

rainersigwald
rainersigwald reviewed Oct 4, 2024
View reviewed changes
rainersigwald
rainersigwald reviewed Oct 4, 2024
View reviewed changes
@YuliiaKovalova YuliiaKovalova merged commit eae7bbd into dotnet:main Oct 8, 2024
10 checks passed
@kasperk81 kasperk81 deleted the collection-expr branch October 8, 2024 08:46
surayya-MS added a commit to surayya-MS/msbuild that referenced this pull request Apr 23, 2025
@surayya-MS
revert "use collection expressions in (non-test) sources (dotnet#10758)"
588aa6b
surayya-MS added a commit to surayya-MS/msbuild that referenced this pull request Apr 23, 2025
@surayya-MS
Revert "revert "use collection expressions in (non-test) sources (dot…
1f786d4 
…net#10758)""

This reverts commit 588aa6b.
This was referenced Jul 28, 2025
Closed
Merged
Closed
Closed
Closed
Open
Open
Open
This was referenced Aug 4, 2025
Open
Open
This was referenced Aug 26, 2025
Closed
Closed
Closed
Closed
Closed
Closed
@dependabot dependabot bot mentioned this pull request Oct 6, 2025
Merged
This was referenced Oct 15, 2025
Open
Closed
Open
Closed
Open
Closed
Open
Open
Closed
Open
Open
Closed
Open
Closed
Open
Open
This was referenced Oct 24, 2025
Open
Open
Open
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rainersigwald rainersigwald rainersigwald approved these changes

@YuliiaKovalova YuliiaKovalova YuliiaKovalova approved these changes

+1 more reviewer

@JanKrivanek JanKrivanek JanKrivanek approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@YuliiaKovalova YuliiaKovalova

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kasperk81 @rainersigwald @JanKrivanek @YuliiaKovalova