-
Couldn't load subscription status.
- Fork 1.9k
[iOS, Mac] Fix for StackLayout not respecting explicit size on iOS and MacCatalyst #32025
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[iOS, Mac] Fix for StackLayout not respecting explicit size on iOS and MacCatalyst #32025
Conversation
|
Hey there @@HarishwaranVijayakumar! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
| var padding = Stack.Padding; | ||
|
|
||
| // If explicit dimensions are set, use them instead of the passed constraints | ||
| var effectiveWidthConstraint = Dimension.IsExplicitSet(Stack.Width) ? Stack.Width : widthConstraint; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is duplicated, could consider extracting to a helper method:
private (double width, double height) GetEffectiveConstraints(
double widthConstraint,
double heightConstraint)
{
return (
Dimension.IsExplicitSet(Stack.Width) ? Stack.Width : widthConstraint,
Dimension.IsExplicitSet(Stack.Height) ? Stack.Height : heightConstraint
);
}
| { | ||
| public Issue14200() | ||
| { | ||
| var verticalStack = new VerticalStackLayout |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider adding a test for HorizontalStackLayout with explicit HeightRequest
Note
Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!
Issue Details
Root Cause of the issue
Description of Change
Issues Fixed
Fixes #14200
Fixes #18450
Tested the behaviour in the following platforms
Output