Skip to content

NativeAOT: Update NativeAOT integration tests to run with 9.0.1xx-preview1 #20268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 31, 2024
Merged

NativeAOT: Update NativeAOT integration tests to run with 9.0.1xx-preview1 #20268

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c7ec58a
Align expected NativeAOT build warning messages in integration tests
ivanpovazan Jan 31, 2024
222cfdc
Do not treat NativeAOT build warnings as errors - introduced with htt…
ivanpovazan Jan 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/TestUtils/src/Microsoft.Maui.IntegrationTests/TemplateTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,6 +195,7 @@ public void PublishNativeAOT(string id, string framework, string runtimeIdentifi
var extendedBuildProps = BuildProps;
extendedBuildProps.Add("PublishAot=true");
extendedBuildProps.Add("PublishAotUsingRuntimePack=true"); // TODO: This parameter will become obsolete https://github.com/dotnet/runtime/issues/87060
extendedBuildProps.Add("IlcTreatWarningsAsErrors=false");

Assert.IsTrue(DotnetInternal.Publish(projectFile, "Release", framework: framework, properties: extendedBuildProps, runtimeIdentifier: runtimeIdentifier),
$"Project {Path.GetFileName(projectFile)} failed to build. Check test output/attachments for errors.");
Expand All @@ -216,6 +217,7 @@ public void PublishNativeAOTCheckWarnings(string id, string framework, string ru
var extendedBuildProps = BuildProps;
extendedBuildProps.Add("PublishAot=true");
extendedBuildProps.Add("PublishAotUsingRuntimePack=true"); // TODO: This parameter will become obsolete https://github.com/dotnet/runtime/issues/87060
extendedBuildProps.Add("IlcTreatWarningsAsErrors=false");
extendedBuildProps.Add("TrimmerSingleWarn=false");

string binLogFilePath = $"publish-{DateTime.UtcNow.ToFileTimeUtc()}.binlog";
Expand Down
15 changes: 0 additions & 15 deletions src/TestUtils/src/Microsoft.Maui.IntegrationTests/Utilities/BuildWarningsUtilities.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,21 +123,6 @@ public static void AssertWarnings(this List<WarningsPerFile> actualWarnings, Lis
// IMPORTANT: Always store expected File information as a relative path to the repo ROOT
private static readonly List<WarningsPerFile> expectedNativeAOTWarnings = new()
{
new WarningsPerFile
{
File = "ILC",
WarningsPerCode = new List<WarningsPerCode>
{
new WarningsPerCode
{
Code = "IL3050",
Messages = new List<string>
{
"<Module>..cctor(): Using member 'System.Enum.GetValues(Type)' which has 'RequiresDynamicCodeAttribute' can break functionality when AOT compiling. It might not be possible to create an array of the enum type at runtime. Use the GetValues<TEnum> overload or the GetValuesAsUnderlyingType method instead.",
}
},
}
},
new WarningsPerFile
{
File = "src/Controls/src/Xaml/XamlParser.cs",
Expand Down