[net10.0] [msbuild] Only decompress binding resource packages remotely. Fixes #23346. #23859

rolfbjarne · 2025-09-19T13:53:14Z

This hopefully fixes a problem where the build would run into MAX_PATH issues
on Windows, because now we won't be extracting any xcframework files on
Windows at all.

Also:

Change the default to always create compressed binding resource packages.
This will ensure NuGets will successfully extract on Windows, because
they'll contain the compressed binding resource package, instead of the
individual files.
Speed up the ResolveNativeReferences task:
- Only run it if there's anything to do.
- Only pass paths that contain references to resolve - this will speed up
  the build on Windows, because it massively reduces the amount of files
  that have to be transferred to the remote mac.

Fixes #23346.

…23346. Also change the default to always create compressed binding resource packages. Fixes #23346.

* Only run it if there's anything to do. * Only pass paths that contain references to resolve - this will speed up the build on Windows, because it massively reduces the amount of files that have to be transferred to the remote mac.

tests/dotnet/UnitTests/TestBaseClass.cs

Always create an entry for directories when creating a zip file. This is what the 'zip' command line tool does, and we also depend on the directory to be in the zip file.

…otely-only-net10.0

vs-mobiletools-engineering-service2 · 2025-10-08T14:56:45Z

✅ [CI Build #70ddd18] Build passed (Build packages) ✅

Pipeline on Agent
Hash: 70ddd182498b4d8c2aab87c157dcfcae2649605a [PR build]

vs-mobiletools-engineering-service2 · 2025-10-08T14:58:19Z

✅ [PR Build #70ddd18] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: 70ddd182498b4d8c2aab87c157dcfcae2649605a [PR build]

vs-mobiletools-engineering-service2 · 2025-10-08T15:25:59Z

✅ API diff for current PR / commit

NET (empty diffs)

iOS: vsdrops gist ( No breaking changes )
tvOS: vsdrops gist ( No breaking changes )
MacCatalyst: vsdrops gist ( No breaking changes )
macOS: vsdrops gist ( No breaking changes )

✅ API diff vs stable

NET (empty diffs)

iOS: vsdrops gist ( No breaking changes )
tvOS: vsdrops gist ( No breaking changes )
MacCatalyst: vsdrops gist ( No breaking changes )
macOS: vsdrops gist ( No breaking changes )

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 70ddd182498b4d8c2aab87c157dcfcae2649605a [PR build]

vs-mobiletools-engineering-service2 · 2025-10-08T15:30:59Z

✅ [CI Build #70ddd18] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: 70ddd182498b4d8c2aab87c157dcfcae2649605a [PR build]

vs-mobiletools-engineering-service2 · 2025-10-08T15:39:46Z

💻 [CI Build #70ddd18] Tests on macOS X64 - Mac Sonoma (14) passed 💻

✅ All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: 70ddd182498b4d8c2aab87c157dcfcae2649605a [PR build]

vs-mobiletools-engineering-service2 · 2025-10-08T15:44:08Z

💻 [CI Build #70ddd18] Tests on macOS M1 - Mac Monterey (12) passed 💻

✅ All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: 70ddd182498b4d8c2aab87c157dcfcae2649605a [PR build]

vs-mobiletools-engineering-service2 · 2025-10-08T15:45:47Z

💻 [CI Build #70ddd18] Tests on macOS M1 - Mac Ventura (13) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: 70ddd182498b4d8c2aab87c157dcfcae2649605a [PR build]

vs-mobiletools-engineering-service2 · 2025-10-08T15:48:02Z

💻 [CI Build #70ddd18] Tests on macOS arm64 - Mac Tahoe (26) passed 💻

✅ All tests on macOS arm64 - Mac Tahoe (26) passed.

Pipeline on Agent
Hash: 70ddd182498b4d8c2aab87c157dcfcae2649605a [PR build]

vs-mobiletools-engineering-service2 · 2025-10-08T15:52:57Z

💻 [CI Build #70ddd18] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

✅ All tests on macOS arm64 - Mac Sequoia (15) passed.

Pipeline on Agent
Hash: 70ddd182498b4d8c2aab87c157dcfcae2649605a [PR build]

vs-mobiletools-engineering-service2 · 2025-10-09T10:41:38Z

🚀 [CI Build #70ddd18] Test results 🚀

Test results

✅ All tests passed on VSTS: test results.

🎉 All 117 tests passed 🎉

Tests counts

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 5 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 6 tests passed. Html Report (VSDrops) Download
✅ linker: All 44 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ monotouch (iOS): All 8 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 11 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 9 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 8 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ windows: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: 70ddd182498b4d8c2aab87c157dcfcae2649605a [PR build]

velocitysystems · 2025-10-21T11:42:19Z

This looks great @rolfbjarne. Will this also be back-ported to .NET 9?

rolfbjarne · 2025-10-21T12:05:23Z

This looks great @rolfbjarne. Will this also be back-ported to .NET 9?

That's unlikely at this point, it's a somewhat invasive/risky change.

rolfbjarne added 2 commits September 19, 2025 15:44

[msbuild] Only decompress binding resource packages remotely. Fixes #…

6acb039

…23346. Also change the default to always create compressed binding resource packages. Fixes #23346.

[msbuild] Improve the ResolveNativeReferences task.

9fa39df

* Only run it if there's anything to do. * Only pass paths that contain references to resolve - this will speed up the build on Windows, because it massively reduces the amount of files that have to be transferred to the remote mac.

rolfbjarne requested review from emaf and mauroa as code owners September 19, 2025 13:53

This was referenced Sep 19, 2025

[msbuild] Only decompress binding resource packages remotely. Fixes #23346. #23797

Closed

[msbuild] Use shorter intermediate paths when extracting files from compressed binding project sidecars. Mitigates #23346. #23639

Closed

This comment has been minimized.

Sign in to view

rolfbjarne enabled auto-merge (squash) September 19, 2025 15:19

rolfbjarne disabled auto-merge September 19, 2025 15:22

[msbuild] Canonicalize zip file paths before processing them.

314645f

This comment has been minimized.

Sign in to view

dalexsoto approved these changes Sep 19, 2025

View reviewed changes

This comment has been minimized.

Sign in to view

mauroa approved these changes Sep 19, 2025

View reviewed changes

tests/dotnet/UnitTests/TestBaseClass.cs Show resolved Hide resolved

velocitysystems mentioned this pull request Sep 23, 2025

Can't process the zip file 'C:\Users\<username>\.nuget\packages\raygun4maui.platform\1.0.2\lib\net7.0-maccatalyst16.1\Raygun4Maui.Binding.NetworkMonitor.iOS.resources.zip' MindscapeHQ/raygun4maui#34

Closed

rolfbjarne and others added 4 commits September 23, 2025 12:21

[msbuild] Treat zip files as files and not directories.

9a27d30

[msbuild] Always create an entry for directories.

a4f6b1f

Always create an entry for directories when creating a zip file. This is what the 'zip' command line tool does, and we also depend on the directory to be in the zip file.

[msbuild] Use a stamp file for copied directories.

929911f

Auto-format source code

7fca827

This comment has been minimized.

Sign in to view

rolfbjarne requested review from dalexsoto and mauroa October 8, 2025 14:17

rolfbjarne added 2 commits October 8, 2025 16:24

[docs] Update docs for CompressBindingResourcePackage.

64d358b

Merge remote-tracking branch 'origin/net10.0' into dev/rolf/unzip-rem…

70ddd18

…otely-only-net10.0

emaf approved these changes Oct 8, 2025

View reviewed changes

mauroa approved these changes Oct 8, 2025

View reviewed changes

This comment has been minimized.

Sign in to view

rolfbjarne merged commit 2321e01 into net10.0 Oct 9, 2025
45 checks passed

rolfbjarne deleted the dev/rolf/unzip-remotely-only-net10.0 branch October 9, 2025 22:17

[net10.0] [msbuild] Only decompress binding resource packages remotely. Fixes #23346. #23859

[net10.0] [msbuild] Only decompress binding resource packages remotely. Fixes #23346. #23859

Uh oh!

Conversation

rolfbjarne commented Sep 19, 2025

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Oct 8, 2025

✅ [CI Build #70ddd18] Build passed (Build packages) ✅

Uh oh!

vs-mobiletools-engineering-service2 commented Oct 8, 2025

✅ [PR Build #70ddd18] Build passed (Detect API changes) ✅

Uh oh!

vs-mobiletools-engineering-service2 commented Oct 8, 2025

✅ API diff for current PR / commit

✅ API diff vs stable

ℹ️ Generator diff

Uh oh!

vs-mobiletools-engineering-service2 commented Oct 8, 2025

✅ [CI Build #70ddd18] Build passed (Build macOS tests) ✅

Uh oh!

vs-mobiletools-engineering-service2 commented Oct 8, 2025

💻 [CI Build #70ddd18] Tests on macOS X64 - Mac Sonoma (14) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Oct 8, 2025

💻 [CI Build #70ddd18] Tests on macOS M1 - Mac Monterey (12) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Oct 8, 2025

💻 [CI Build #70ddd18] Tests on macOS M1 - Mac Ventura (13) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Oct 8, 2025

💻 [CI Build #70ddd18] Tests on macOS arm64 - Mac Tahoe (26) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Oct 8, 2025

💻 [CI Build #70ddd18] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

Uh oh!

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Oct 9, 2025

🚀 [CI Build #70ddd18] Test results 🚀

Test results

Tests counts

Uh oh!

Uh oh!

velocitysystems commented Oct 21, 2025

Uh oh!

rolfbjarne commented Oct 21, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants