[Xamarin.MacDev] Add an AppleSdkVersion struct which replaces IPhoneSdkVersion and MacOSXSdkVersion. #87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dkVersion and MacOSXSdkVersion. This reduces code duplication and makes it possible to simplify logic in a few places.
dalexsoto
approved these changes
Feb 11, 2021
spouliot
approved these changes
Feb 11, 2021
spouliot
left a comment
spouliot
left a comment
There was a problem hiding this comment.
comments are not related to the renaming itself
| AppleSdkVersion.V10_11, | ||
| AppleSdkVersion.V10_12, | ||
| AppleSdkVersion.V10_13, | ||
| AppleSdkVersion.V10_14, |
There was a problem hiding this comment.
not sure who use the API but should include 10.15, 11.[0-3] ?
Also not so clear about the new minor version of 11.x
Member
Author
There was a problem hiding this comment.
I believe VSMac are using these.
I didn't want to remove any that VSMac might be using (nor add any VSMac isn't using).
| AppleSdkVersion.V9_2, | ||
| AppleSdkVersion.V9_3, | ||
| AppleSdkVersion.V10_0, | ||
| AppleSdkVersion.V10_1 |
There was a problem hiding this comment.
same comment, that seems incomplete
who's using this ?
| AppleSdkVersion.V10_9, | ||
| AppleSdkVersion.V10_10, | ||
| AppleSdkVersion.V10_11, | ||
| AppleSdkVersion.V10_12 |
There was a problem hiding this comment.
more missing versions
should not it be identical to the previous one ?
emaf
approved these changes
Feb 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reduces code duplication and makes it possible to simplify logic in a few places.