[Java.Interop.BootstrapTasks] <JdkInfo/> requires include dir
#366
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Microsoft OpenJDK package does *not* contain the `includes` directory, or `jdk.h`, or anything else needed to build native code. Consequently, it is not useful for *building* Java.Interop. Update the `<JdkInfo/>` task to require that `JdkInfo.IncludePath` includes directories. (We don't currently check that `jdk.h` exists, but we could do so in the future if necessary.) This causes the Microsoft OpenJDK package to be *skipped* during `make prepare`, causing the Java.Interop build to instead use a "system" JDK installation which *does* provide the `include` directories.
grendello
approved these changes
Sep 4, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Microsoft OpenJDK package does not contain the
includesdirectory, or
jdk.h, or anything else needed to build native code.Consequently, it is not useful for building Java.Interop.
Update the
<JdkInfo/>task to require thatJdkInfo.IncludePathincludes directories. (We don't currently check that
jdk.hexists,but we could do so in the future if necessary.) This causes the
Microsoft OpenJDK package to be skipped during
make prepare,causing the Java.Interop build to instead use a "system" JDK
installation which does provide the
includedirectories.