[jnimarshalmethod-gen] Delete the temporary files #301
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radekdoulik
force-pushed
the
pr-remove-temporary-files-work-in-separate-appdomain
branch
from
6baca21 to
55cf0d6
Compare
jonpryor
reviewed
Apr 19, 2018
tools/jnimarshalmethod-gen/App.cs
Outdated
| { "d|debug", | ||
| "Inject debug messages", | ||
| v => Debug = true }, | ||
| { "k|keep-temporary", |
Contributor
There was a problem hiding this comment.
This should be keeptemp, as that's what mkbundle uses.
I also don't think it needs a "short" -k form.
We don't want to leave the `*-JniMarshalMethods.dll` files behind, so we need to delete them, once the methods are moved back to the originating assemblies. Because the dynamic assembly builder needs to save the temporary assembly, we need it to use `AssemblyBuilderAccess.Save`, which means the assembly cannot be unloaded from the domain. Thus we do the work in separate `AppDomain` and unload the whole domain at the end, so that the temporary files are not locked anymore. A bit of refactoring was needed for that. There is also new `--keeptemp` option to enable the old behavior and keep the temporary files. And finally the help message is printed when no arguments supplied. Plus new error message in case no assemblies were specified.
radekdoulik
force-pushed
the
pr-remove-temporary-files-work-in-separate-appdomain
branch
from
55cf0d6 to
c7678bc
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't want to leave the
*-JniMarshalMethods.dllfiles behind, sowe need to delete them, once the methods are moved back to the
originating assemblies.
Because the dynamic assembly builder needs to save the temporary
assembly, we need it to use
AssemblyBuilderAccess.Save, which meansthe assembly cannot be unloaded from the domain.
Thus we do the work in separate
AppDomainand unload the wholedomain at the end, so that the temporary files are not locked
anymore. A bit of refactoring was needed for that.
There is also new
--keeptempoption to enable the old behavior andkeep the temporary files.
And finally the help message is printed when no arguments
supplied. Plus new error message in case no assemblies were specified.