-
Notifications
You must be signed in to change notification settings - Fork 62
[generator] Fix Formatted() overloads & parameter aliases #185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
33 changes: 33 additions & 0 deletions
33
tools/generator/Tests/SupportFiles/Android_Runtime_CharSequence.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| using System; | ||
| using System.Collections.Generic; | ||
|
|
||
| namespace Android.Runtime { | ||
|
|
||
| public static class CharSequence | ||
| { | ||
| public static Java.Lang.ICharSequence [] ArrayFromStringArray (string [] val) | ||
| { | ||
| throw new NotImplementedException (); | ||
| } | ||
|
|
||
| public static string [] ArrayToStringArray (Java.Lang.ICharSequence [] val) | ||
| { | ||
| throw new NotImplementedException (); | ||
| } | ||
|
|
||
| public static IntPtr ToLocalJniHandle (string value) | ||
| { | ||
| throw new NotImplementedException (); | ||
| } | ||
|
|
||
| public static IntPtr ToLocalJniHandle (Java.Lang.ICharSequence value) | ||
| { | ||
| throw new NotImplementedException (); | ||
| } | ||
|
|
||
| public static IntPtr ToLocalJniHandle (IEnumerable<char> value) | ||
| { | ||
| throw new NotImplementedException (); | ||
| } | ||
| } | ||
| } |
13 changes: 13 additions & 0 deletions
13
tools/generator/Tests/SupportFiles/Java_Lang_ICharSequence.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| using System; | ||
| using Android.Runtime; | ||
|
|
||
| namespace Java.Lang { | ||
|
|
||
| public partial interface ICharSequence : IJavaObject | ||
| { | ||
| char CharAt (int index); | ||
| int Length (); | ||
| Java.Lang.ICharSequence SubSequenceFormatted (int start, int end); | ||
| string ToString (); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,43 @@ | ||
| using System; | ||
| using System.Collections; | ||
| using System.Collections.Generic; | ||
|
|
||
| namespace Java.Lang { | ||
|
|
||
| public sealed partial class String : global::Java.Lang.Object, Java.Lang.ICharSequence | ||
| { | ||
| public String (string value) | ||
| { | ||
| } | ||
|
|
||
| public char CharAt (int index) | ||
| { | ||
| throw new NotImplementedException (); | ||
| } | ||
|
|
||
| public int Length () | ||
| { | ||
| throw new NotImplementedException (); | ||
| } | ||
|
|
||
| public Java.Lang.ICharSequence SubSequenceFormatted (int start, int end) | ||
| { | ||
| throw new NotImplementedException (); | ||
| } | ||
|
|
||
| public override string ToString () | ||
| { | ||
| throw new NotImplementedException (); | ||
| } | ||
|
|
||
| public IEnumerator<char> GetEnumerator () | ||
| { | ||
| throw new NotImplementedException (); | ||
| } | ||
|
|
||
| IEnumerator IEnumerable.GetEnumerator () | ||
| { | ||
| throw new NotImplementedException (); | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it a safe assumption that our product support only C# 6.0 or higher?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(The same comment applies to a couple of other parts in the changes too.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps not. Would you prefer I not use C#6 features in the binding?