Add project for cook book utilities #3217
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonsequitur
reviewed
Oct 3, 2023
|
|
||
| namespace Microsoft.DotNet.Interactive.AIUtilities; | ||
|
|
||
| public static class TextChunkingExtensions |
Contributor
There was a problem hiding this comment.
Thoughts on a better name? What else is going to end up in the category of string operations?
Member
Author
There was a problem hiding this comment.
mm probably will be template parameter parsing?
jonsequitur
reviewed
Oct 4, 2023
| }; | ||
|
|
||
| Func<string, float[]> stringToFloatArray = a => a.Select(c => (float)c).ToArray(); | ||
| var search = collection.Search( |
Contributor
There was a problem hiding this comment.
I don't understand this signature very well. Let's work on simplifying.
jonsequitur
reviewed
Oct 4, 2023
| public float Score(T a, TQuery query); | ||
| } | ||
|
|
||
| public class CosineSimilarityComparer<T> : ISimilarityComparer<T, float[]> |
jonsequitur
reviewed
Oct 4, 2023
src/Microsoft.DotNet.Interactive.AIUtilities/SemanticCollection.cs
Outdated
Show resolved
Hide resolved
jonsequitur
reviewed
Oct 4, 2023
| }; | ||
|
|
||
| var search = collection.OrderBySimilarity( | ||
| var search = collection.ScoreBySimilarity( |
Contributor
There was a problem hiding this comment.
Maybe ScoreBySimilarityTo("diego")?
jonsequitur
approved these changes
Oct 5, 2023
19 tasks
colombod
added
the
Area-Build & Infrastructure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding