Skip to content

Conversation

@sbomer
Copy link
Member

@sbomer sbomer commented Dec 8, 2022

Part of dotnet/linker#3029. With https://github.com/dotnet/sdk/pull/29441/files, this will enable the SDK to use a different version of illink depending on the TFM.

The latest 7.0 illink package is used when trimming net7.0 and earlier, which matches the configuration we shipped in the .NET 7 SDK.

These versions will quickly get out of date and need to be kept updated. For the latest (8.0) version I think it would be possible to set up dependency flow from linker -> installer to automate this, but I would rather wait for the linker move to dotnet/runtime, which will allow us to use $(MicrosoftNETCoreAppRuntimePackageVersion) for the latest illink pack. (dotnet/linker#3153 will update this version number to begin with 8).

Unfortunately the 7.0 version will still need manual updates. We might want to consider changing our version numbers to match dotnet/runtime, but AFAIK that will still be a manual process (to update the patch number in the release/7.0 branch of dotnet/linker every SDK servicing release).

<KnownILLinkPack Include="Microsoft.NET.ILLink.Tasks"
TargetFramework="net8.0"
ILLinkPackVersion="7.0.100-1.22606.1" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this version intended to be hard-coded until the linker moves into the runtime repo?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that's my intention. @tlakollo is working on building ILLink packages in dotnet/runtime so I think this will be possible soon. Until then I can bump it manually.

@sbomer sbomer enabled auto-merge December 21, 2022 00:55
@sbomer sbomer merged commit fe452cf into dotnet:main Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants