Skip to content

Conversation

vlada-shubina
Copy link
Member

@vlada-shubina vlada-shubina commented Dec 7, 2020

fixes #116 and #105 (comment)

Starting 5.0, use <feed location>/WindowsDesktop for windowsdesktop runtime.

@vlada-shubina vlada-shubina requested a review from a team December 7, 2020 16:39
@vlada-shubina vlada-shubina self-assigned this Dec 7, 2020
@vlada-shubina
Copy link
Member Author

@mmitche This fix needs the latest.version files to be copied from Runtime to WindowsDesktop, is it possible?
At least the following, not sure if there are more:

  • https://dotnetcli.azureedge.net/dotnet/WindowsDesktop/LTS/latest.version
  • https://dotnetcli.azureedge.net/dotnet/WindowsDesktop/Current/latest.version
  • https://dotnetcli.azureedge.net/dotnet/WindowsDesktop/<version in A.B format>/latest.version

Alternatively, I can add the following check:

  • if channel starts with 5 or later, check https://dotnetcli.azureedge.net/dotnet/WindowsDesktop/<channel name>/latest.version
  • otherwise, check https://dotnetcli.azureedge.net/dotnet/Runtime/<channel name>/latest.version

@mmitche
Copy link
Member

mmitche commented Dec 7, 2020

@mmitche This fix needs the latest.version files to be copied from Runtime to WindowsDesktop, is it possible?
At least the following, not sure if there are more:

  • https://dotnetcli.azureedge.net/dotnet/WindowsDesktop/LTS/latest.version
  • https://dotnetcli.azureedge.net/dotnet/WindowsDesktop/Current/latest.version
  • https://dotnetcli.azureedge.net/dotnet/WindowsDesktop/<version in A.B format>/latest.version

Alternatively, I can add the following check:

  • if channel starts with 5 or later, check https://dotnetcli.azureedge.net/dotnet/WindowsDesktop/<channel name>/latest.version
  • otherwise, check https://dotnetcli.azureedge.net/dotnet/Runtime/<channel name>/latest.version

Should be. @rbhanda can take care of that.

@bekir-ozturk
Copy link
Contributor

@mmitche

        Matt Mitchell
        FTE This fix needs the `latest.version` files to be copied from `Runtime` to `WindowsDesktop`, is it possible?

At least the following, not sure if there are more:

  • https://dotnetcli.azureedge.net/dotnet/WindowsDesktop/LTS/latest.version
  • https://dotnetcli.azureedge.net/dotnet/WindowsDesktop/Current/latest.version
  • https://dotnetcli.azureedge.net/dotnet/WindowsDesktop/<version in A.B format>/latest.version

Alternatively, I can add the following check:

  • if channel starts with 5 or later, check https://dotnetcli.azureedge.net/dotnet/WindowsDesktop/<channel name>/latest.version
  • otherwise, check https://dotnetcli.azureedge.net/dotnet/Runtime/<channel name>/latest.version

Should be. @rbhanda Rahul Bhandari (DEVDIV) FTE can take care of that.

@mmitche @rbhanda Do you have this scheduled?
To clarify, we won't move the files, but copy them, right? Otherwise, anyone using the old version of the script will run into issues.

@bekir-ozturk bekir-ozturk requested review from a team and bekir-ozturk January 13, 2021 12:45
@rbhanda
Copy link

rbhanda commented Jan 14, 2021

}
else
{
$ProductVersionTxtURL = "$AzureFeed/Runtime/$SpecificVersion/productVersion.txt"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was the use of this productVersion.txt always there? I think it's not produced for 3.1 and prior.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, we try to read productVersion.txt for all versions, but default to package version in case productVersion.txt is not found.

@bekir-ozturk bekir-ozturk merged commit 98011e4 into dotnet:master Feb 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change the path for windows desktop runtime packages
5 participants