added --os option to bash script #118
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vlada-shubina
commented
Dec 4, 2020
| @@ -40,7 +40,7 @@ if [ -t 1 ] && command -v tput > /dev/null; then | |||
| fi | |||
|
|
|||
| say_warning() { | |||
| printf "%b\n" "${yellow:-}dotnet_install: Warning: $1${normal:-}" | |||
| printf "%b\n" "${yellow:-}dotnet_install: Warning: $1${normal:-}" >&3 | |||
There was a problem hiding this comment.
this fix is needed so warnings are done to standard output (see line 20)
| @@ -1074,6 +1109,11 @@ do | |||
| echo " --architecture <ARCHITECTURE> Architecture of dotnet binaries to be installed, Defaults to \`$architecture\`." | |||
| echo " --arch,-Architecture,-Arch" | |||
| echo " Possible values: x64, arm, and arm64" | |||
| echo " --os <system> Specifies operating system to be used when selecting the installer." | |||
| echo " Overrides the OS determination approach used by the script. Supported values: osx, linux, linux-musl, freebsd, rhel.6." | |||
There was a problem hiding this comment.
This list doesn't include supported OS for legacy links. As mentioned in 1st comment I don't want to mix them, as it increases chance of error.
My suggestion for those who still on legacy versions to continue to use --runtime-id to override OS if needed.
There was a problem hiding this comment.
That sounds reasonable to me.
bekir-ozturk
approved these changes
Dec 7, 2020
AR-May
approved these changes
Dec 8, 2020
…ecture is given replaced legacy links reference in help with versions below 2.1
vlada-shubina
force-pushed
the
os-option
branch
from
3328f3b to
224edd1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements suggestion in: #13 (comment)
--os option allows user to specify the OS to be used when selecting the installation package.
Important notes to review:
linux, linux-musl, osx, freebsd, rhel.6- aligned with possible choices for OS auto-detection. I'm not sure about includingfreebsdandrhel.6- I haven't seen and freebsd specific packages, and packages forrhel.6are rare. According to https://github.com/dotnet/installer rhel.6 packages are only available for 3.1. As alternative, we can include them but add warning that some versions might not support them.Powershell script is hardcoded to use "win" as OS, I see no point in making --os version for powershell.