Skip to content

Commit 3328f3b

Browse files
committed
changed behavior to exit with error when unsupported value for architecture is given
replaced legacy links reference in help with versions below 2.1
1 parent d68dee3 commit 3328f3b

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

src/dotnet-install.sh

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -357,8 +357,8 @@ get_normalized_os() {
357357
return 0
358358
;;
359359
*)
360-
say_warning "'$user_defined_os' is not a valid platform. The platform will be evaluated based on machine configuration."
361-
osname="$(get_current_os_name)" || return 1
360+
say_err "'$user_defined_os' is not a supported value for --os option, supported values are: osx, linux, linux-musl, freebsd, rhel.6. If you think this is a bug, report it at https://github.com/dotnet/install-scripts/issues."
361+
return 1
362362
;;
363363
esac
364364
else
@@ -1069,7 +1069,7 @@ do
10691069
shift
10701070
runtime_id="$1"
10711071
non_dynamic_parameters+=" $name "\""$1"\"""
1072-
say_warning "Use of --runtime-id is obsolete and should be limited to legacy versions only. To override architecture, use --architecture option instead. To override OS, use --os option instead."
1072+
say_warning "Use of --runtime-id is obsolete and should be limited to the versions below 2.1. To override architecture, use --architecture option instead. To override OS, use --os option instead."
10731073
;;
10741074
--jsonfile|-[Jj][Ss]on[Ff]ile)
10751075
shift
@@ -1137,7 +1137,7 @@ do
11371137
echo " This parameter is obsolete and may be removed in a future version of this script."
11381138
echo " Installs just the shared runtime bits, not the entire SDK."
11391139
echo " --runtime-id Installs the .NET Tools for the given platform (use linux-x64 for portable linux)."
1140-
echo " -RuntimeId" The parameter is obsolete and may be removed in a future version of this script. Should be used for legacy links only.
1140+
echo " -RuntimeId" The parameter is obsolete and may be removed in a future version of this script. Should be used only for versions below 2.1.
11411141
echo " For primary links to override OS or/and architecture, use --os and --architecture option instead."
11421142
echo ""
11431143
echo "Install Location:"

0 commit comments

Comments
 (0)