Run ILVerify #17953
Merged
Run ILVerify #17953
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
✅ No release notes required |
vzarytovskii
commented
Nov 4, 2024
T-Gro
reviewed
Nov 5, 2024
T-Gro
reviewed
Nov 5, 2024
Member
Author
|
Separated baselines, if it succeeds, it's ready. |
T-Gro
approved these changes
Nov 5, 2024
Member
|
The CI step feels wrong - it finished in 1m30s only, I think it did not do the build at all. |
T-Gro
requested changes
Nov 5, 2024
Member
T-Gro
left a comment
T-Gro
left a comment
There was a problem hiding this comment.
See CI - was too fast and did not error.
Member
Author
Ah, path issue, gonna fix it tomorrow |
Member
Author
|
Wasn't the path issue, but the issue of me commenting out part of the script to test locally, and forgetting to uncomment. Script will also fail now if the DLL is not on the path. |
Member
Author
|
@T-Gro this is passing now: Also checked with false positives (invalid baselines) - resulted in the step failure. |
T-Gro
approved these changes
Nov 6, 2024
0101
approved these changes
Nov 7, 2024
This was referenced Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Run ilverify on each PR. Currently it fails on a bunch of "invalid" codegen. Not sure if it makes sense to ignore current one, or create a baseline (which would be much better).
I will see how it runs in CI and create a baseline, so no new codegen changes are introduced.