Skip to content

Fixed find-all refs not looking at all files/projects #10207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TIHan merged 1 commit into from
Oct 2, 2020
Merged

Fixed find-all refs not looking at all files/projects #10207

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion vsintegration/src/FSharp.Editor/Navigation/FindUsagesService.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,8 @@ type internal FSharpFindUsagesService
|> Option.defaultValue externalDefinitionItem

let referenceItem = FSharpSourceReferenceItem(definitionItem, FSharpDocumentSpan(doc, textSpan))
do! context.OnReferenceFoundAsync(referenceItem) |> Async.AwaitTask }
// REVIEW: OnReferenceFoundAsync is throwing inside Roslyn, putting a try/with so find-all refs doesn't fail.
try do! context.OnReferenceFoundAsync(referenceItem) |> Async.AwaitTask with | _ -> () }

match symbolUse.GetDeclarationLocation document with
| Some SymbolDeclarationLocation.CurrentDocument ->
Expand Down