Skip to content

Conversation

@stephentoub
Copy link
Member

@stephentoub stephentoub commented Nov 22, 2025

Microsoft Reviewers: Open in CodeFlow

@stephentoub stephentoub requested a review from ericstj November 22, 2025 03:22
@stephentoub stephentoub requested a review from a team as a code owner November 22, 2025 03:22
Copilot AI review requested due to automatic review settings November 22, 2025 03:22
@github-actions github-actions bot added the area-ai Microsoft.Extensions.AI libraries label Nov 22, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes package references in Microsoft.Extensions.AI packages by conditionally including certain framework-provided packages only for target frameworks older than .NET 10.0. The changes ensure that packages like System.Text.Json, System.Diagnostics.DiagnosticSource, and System.Threading.Channels are only referenced when targeting frameworks that don't include them in the base framework.

Key changes:

  • Adds conditional package references for .NET 10.0 compatibility across AI libraries
  • Removes System.Memory.Data package references from OpenAI and AzureAIInference projects

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
Microsoft.Extensions.AI.csproj Adds condition to exclude System.Diagnostics.DiagnosticSource, System.Text.Json, and System.Threading.Channels for net10.0+
Microsoft.Extensions.AI.OpenAI.csproj Removes System.Memory.Data reference and conditionally excludes System.Text.Json for net10.0+
Microsoft.Extensions.AI.AzureAIInference.csproj Removes System.Memory.Data reference and conditionally excludes System.Text.Json for net10.0+
Microsoft.Extensions.AI.Abstractions.csproj Adds condition to exclude System.Text.Json for net10.0+

@stephentoub
Copy link
Member Author

I think the failure here will be addressed by #7078

@stephentoub stephentoub merged commit 73810ce into dotnet:main Nov 25, 2025
6 checks passed
This was referenced Dec 11, 2025
This was referenced Dec 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-ai Microsoft.Extensions.AI libraries

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants