-
Notifications
You must be signed in to change notification settings - Fork 849
Fix package references from M.E.AI packages #7076
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR fixes package references in Microsoft.Extensions.AI packages by conditionally including certain framework-provided packages only for target frameworks older than .NET 10.0. The changes ensure that packages like System.Text.Json, System.Diagnostics.DiagnosticSource, and System.Threading.Channels are only referenced when targeting frameworks that don't include them in the base framework.
Key changes:
- Adds conditional package references for .NET 10.0 compatibility across AI libraries
- Removes System.Memory.Data package references from OpenAI and AzureAIInference projects
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| Microsoft.Extensions.AI.csproj | Adds condition to exclude System.Diagnostics.DiagnosticSource, System.Text.Json, and System.Threading.Channels for net10.0+ |
| Microsoft.Extensions.AI.OpenAI.csproj | Removes System.Memory.Data reference and conditionally excludes System.Text.Json for net10.0+ |
| Microsoft.Extensions.AI.AzureAIInference.csproj | Removes System.Memory.Data reference and conditionally excludes System.Text.Json for net10.0+ |
| Microsoft.Extensions.AI.Abstractions.csproj | Adds condition to exclude System.Text.Json for net10.0+ |
|
I think the failure here will be addressed by #7078 |
Microsoft Reviewers: Open in CodeFlow