Cosmos: Complex properties Query #37577
Draft
+1,757
−208
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoasE
commented
Jan 29, 2026
| context.AddRange( | ||
| new Context33449.EntityType | ||
| { | ||
| Id = 1, |
Contributor
Author
There was a problem hiding this comment.
TODO: This breaks sql tests, but is needed for cosmos to work. Can we generate a value on add..?
| } | ||
|
|
||
| public override async Task Contains_with_nested_and_composed_operators() | ||
| => await AssertTranslationFailed(base.Contains_with_nested_and_composed_operators); // Complex collection equality... Need ALL support |
Contributor
Author
There was a problem hiding this comment.
Is there an issue for this?
| return expression; | ||
| } | ||
|
|
||
| // This is for list.Contains(entity) |
Contributor
Author
There was a problem hiding this comment.
TODO? No wait don't think so, this isn't supported right?
| return source; | ||
| } | ||
|
|
||
| private static bool IsProjectionCompatibleWithDistinct(Expression shaperExpression) // @TODO: Is there a better way to do this? // @TODO: Check if binding is done on client eval..? |
|
|
||
| Check.DebugAssert(entityType != null, "At least either side should be entityReference so entityType should be non-null."); | ||
| var obj = structuralReference.Object; | ||
| if (obj is StructuralTypeShaperExpression { ValueBufferExpression: ProjectionBindingExpression { QueryExpression: SelectExpression select } }) // @TODO: Is this the right way to check if this is a query object reference? |
| // x.Collection == x.Collection (should return null) | ||
| // x.Collection[1] == x.Collection[1] (should run below) | ||
| // How can we determine the difference? The structuralReference represents the entire complex type in both scenarios, wich is always of type ComplexType and IsCollection true.. | ||
| if (structuralReference.Parameter?.ValueBufferExpression is ObjectArrayAccessExpression) // @TODO: Is there a better way to do this? It feels like this might not be the right place. What about CosmosQueryableMethodTranslatingExpressionVisitor? What is the difference again? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds Cosmos Db query pipeline support for complex properties