Handle private properties in the compiled model #33409
Conversation
AndriySvyryd
force-pushed
the
Issue29761
branch
from
87952ec to
8048cab
Compare
| public static string GetUnsafeAccessorName(MemberInfo member) | ||
| { | ||
| StringBuilder stringBuilder = new(); | ||
| stringBuilder.Clear().Append("UnsafeAccessor_"); |
There was a problem hiding this comment.
Is this our naming convention, or a convention recommended from somewhere else?
There was a problem hiding this comment.
I don't think there's a specific recommended naming convention for unsafe accessor (see API docs with samples), this is also what I used on the query side when generating these.
No strong feelings of course (this is all "internal" generated code), it just seemed like a code idea to identify what these methods are etc.
There was a problem hiding this comment.
I just noticed that it generates very long names. Not a big deal, but given the size of generated code has been an issue it was something that occurred to me.
There was a problem hiding this comment.
I just made it consistent with what query generates. The idea is to have a unique name that still means something. If Shay agrees we can just use the member name + uniquefier to keep it short.
There was a problem hiding this comment.
Sure, am fine with whatever - remember this is just generated code so nothing's very important here (except for uniqueness).
| { | ||
| if (assignmentKind is not SyntaxKind.SimpleAssignmentExpression) | ||
| { | ||
| throw new NotSupportedException("Compound assignment not supported"); |
There was a problem hiding this comment.
This is from Shay's PR, I was reading this as "not implemented", we could handle compound assignments by calling the getter and then the setter
...FCore.InMemory.FunctionalTests/Scaffolding/Baselines/ComplexTypes/PrincipalBaseEntityType.cs
Outdated
Show resolved
Hide resolved
Add full support for service properties
Use a consistent pattern for unsafe accessors
Store the unsafe accessor names in an annotation
Refactor the different mechanisms for tracking variables in the generated code into a single bidirectional dictionary
Fixes #29761
Fixes #24904
Fixes #24900