[release/7.0] Avoid redundant looping in property metadata #29807
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndriySvyryd
force-pushed
the
Issue29642_7.0
branch
from
e245aa4 to
c5563e3
Compare
AndriySvyryd
force-pushed
the
Issue29642_7.0
branch
from
c5563e3 to
edc4ec3
Compare
roji
changed the title
ajcvickers
approved these changes
Dec 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a port of #29805
Fixes #29642
Description
The logic for reading property metadata is performing more loops than intended resulting in poor model building performance (affects migrations and app startup).
Customer impact
Non-trivial models take up to three times as long to build. There is no workaround.
How found
Customer reported on 7.0
Regression
Yes.
Testing
Manual verification of the performance.
Risk
Low; the fix should not have any behavior impact, and a quirk was added to revert back to older behavior.