Benchmarks: Refactor benchmarks to be provider agnostic #11086
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
cc: @roji |
smitpatel
commented
Feb 27, 2018
| public static class AdventureWorksFixture | ||
| { | ||
| // TODO: No database for Sqlite | ||
| private static string _connectionString = $"DataSource=AdventureWorks2014;"; |
Contributor
Author
There was a problem hiding this comment.
@bricelam some of our tests uses AdventureWorks database. To run those tests, we would need copy of the database for Sqlite.
Contributor
There was a problem hiding this comment.
As discussed offline, use .EnsureCreated() to create the schema, select the data from SQL Server and insert into SQLite.
Contributor
Author
There was a problem hiding this comment.
Can you file an issue for that?
smitpatel
commented
Feb 27, 2018
| protected override string StoredProcedureCreationScript | ||
| => @""; | ||
|
|
||
| // TODO: Define stored procedure creation script |
Contributor
Author
There was a problem hiding this comment.
@bricelam how to define a stored procedure in sqlite? We have definition for SqlServer right now. It is used in a test where FromSql is used with sproc
Contributor
There was a problem hiding this comment.
No procedures in SQLite--just TVFs.
smitpatel
force-pushed
the
smit/benchmarks
branch
from
5dd16d4 to
09f5704
Compare
AndriySvyryd
approved these changes
Feb 28, 2018
Run benchmarks for Sqlite provider Resolves #9681
smitpatel
force-pushed
the
smit/benchmarks
branch
from
09f5704 to
0ab0729
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Run benchmarks for Sqlite provider
Resolves #9681